From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-media@vger.kernel.org,
Sergio Aguirre <sergio.a.aguirre@gmail.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [PATCH v2 01/18] v4l: omap4iss: Add support for OMAP4 camera interface - Core
Date: Tue, 03 Dec 2013 18:14:15 +0100 [thread overview]
Message-ID: <1506831.WPYrDVrDpX@avalon> (raw)
In-Reply-To: <20131203150243.33a00f58.m.chehab@samsung.com>
Hi Mauro,
On Tuesday 03 December 2013 15:02:43 Mauro Carvalho Chehab wrote:
> Em Mon, 4 Nov 2013 01:06:26 +0100
>
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> > From: Sergio Aguirre <sergio.a.aguirre@gmail.com>
> >
> > This adds a very simplistic driver to utilize the CSI2A interface inside
> > the ISS subsystem in OMAP4, and dump the data to memory.
> >
> > Check Documentation/video4linux/omap4_camera.txt for details.
> >
> > This commit adds the driver core, registers definitions and
> > documentation.
> >
> > Signed-off-by: Sergio Aguirre <sergio.a.aguirre@gmail.com>
> >
> > [Port the driver to v3.12-rc3, including the following changes
> > - Don't include plat/ headers
> > - Don't use cpu_is_omap44xx() macro
> > - Don't depend on EXPERIMENTAL
> > - Fix s_crop operation prototype
> > - Update link_notify prototype
> > - Rename media_entity_remote_source to media_entity_remote_pad]
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >
> > Documentation/video4linux/omap4_camera.txt | 60 ++
> > drivers/staging/media/omap4iss/iss.c | 1477 +++++++++++++++++++++++
> > drivers/staging/media/omap4iss/iss.h | 153 +++
> > drivers/staging/media/omap4iss/iss_regs.h | 883 +++++++++++++++++
> > include/media/omap4iss.h | 65 ++
> > 5 files changed, 2638 insertions(+)
> > create mode 100644 Documentation/video4linux/omap4_camera.txt
> > create mode 100644 drivers/staging/media/omap4iss/iss.c
> > create mode 100644 drivers/staging/media/omap4iss/iss.h
> > create mode 100644 drivers/staging/media/omap4iss/iss_regs.h
> > create mode 100644 include/media/omap4iss.h
>
> ...
>
> > + /*
> > + * atomic_set() doesn't include memory barrier on ARM platform for
SMP
> > + * scenario. We'll call it here to avoid race conditions.
> > + */
> > + atomic_set(stopping, 1);
> > + smp_wmb();
>
> Hmm... if atomic_set() is broken on ARM, you should be fixing its
> implementation, and not adding any hacks like the above on all places
> where atomic ops are needed.
I'll investigate that. Can I address that in a follow-up patch ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-12-03 17:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 0:06 [PATCH v2 00/18] OMAP4 ISS driver Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 01/18] v4l: omap4iss: Add support for OMAP4 camera interface - Core Laurent Pinchart
2013-12-03 17:02 ` Mauro Carvalho Chehab
2013-12-03 17:14 ` Laurent Pinchart [this message]
2013-11-04 0:06 ` [PATCH v2 02/18] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 03/18] v4l: omap4iss: Add support for OMAP4 camera interface - CSI receivers Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 04/18] v4l: omap4iss: Add support for OMAP4 camera interface - IPIPE(IF) Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 05/18] v4l: omap4iss: Add support for OMAP4 camera interface - Resizer Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 06/18] v4l: omap4iss: Add support for OMAP4 camera interface - Build system Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 07/18] v4l: omap4iss: Don't use v4l2_g_ext_ctrls() internally Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 08/18] v4l: omap4iss: Move common code out of switch...case Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 09/18] v4l: omap4iss: Report device caps in response to VIDIOC_QUERYCAP Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 10/18] v4l: omap4iss: Remove iss_video streaming field Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 11/18] v4l: omap4iss: Set the vb2 timestamp type Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 12/18] v4l: omap4iss: Remove duplicate video_is_registered() check Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 13/18] v4l: omap4iss: Remove unneeded status variable Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 14/18] v4l: omap4iss: Replace udelay/msleep with usleep_range Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 15/18] v4l: omap4iss: Make omap4iss_isp_subclk_(en|dis)able() functions void Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 16/18] v4l: omap4iss: Make loop counters unsigned where appropriate Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 17/18] v4l: omap4iss: Don't initialize fields to 0 manually Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 18/18] v4l: omap4iss: Simplify error paths Laurent Pinchart
2013-11-04 9:41 ` [PATCH v2 00/18] OMAP4 ISS driver Hans Verkuil
2013-11-04 10:59 ` Hans Verkuil
2013-11-04 10:04 ` [PATCH v2 19/18] v4l: omap4iss: Don't check for missing get_fmt op on remote subdev Laurent Pinchart
2013-11-04 10:04 ` [PATCH v2 20/18] v4l: omap4iss: Translate -ENOIOCTLCMD to -ENOTTY Laurent Pinchart
2013-11-04 10:04 ` [PATCH v2 21/18] v4l: omap4iss: Move code out of mutex-protected section Laurent Pinchart
2013-11-04 10:04 ` [PATCH v2 22/18] v4l: omap4iss: Implement VIDIOC_S_INPUT Laurent Pinchart
2013-11-04 10:06 ` [PATCH v2 00/18] OMAP4 ISS driver Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506831.WPYrDVrDpX@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=sakari.ailus@iki.fi \
--cc=sergio.a.aguirre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox