Re: [PATCH] dma-buf: Fix ifnullfree.cocci warnings

Sumit Semwal
2017-11-23T10:46:17Z

Hello Vasyl,

On 22 November 2017 at 20:52, Vasyl Gomonovych <gomonovych@gmail.com> wrote:
> NULL check before some freeing functions is not needed.
> drivers/dma-buf/dma-buf.c:1183:2-26: WARNING: NULL check before freeing debugfs_remove_recursive
> Generated by: scripts/coccinelle/free/ifnullfree.cocci

Thank you for your patch; applied to drm-misc-next.
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> drivers/dma-buf/dma-buf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index 4a038dcf5361..048827b06c03 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -1179,8 +1179,7 @@ static int dma_buf_init_debugfs(void)
>
> static void dma_buf_uninit_debugfs(void)
> {
> - if (dma_buf_debugfs_dir)
> - debugfs_remove_recursive(dma_buf_debugfs_dir);
> + debugfs_remove_recursive(dma_buf_debugfs_dir);
> }
> #else
> static inline int dma_buf_init_debugfs(void)
> --
> 1.9.1
>

--
Thanks and regards,

Sumit Semwal
Linaro Mobile Group - Kernel Team Lead
Linaro.org │ Open source software for ARM SoCs