Re: [RFC PATCH 2/3] ir-rc5-sz: Add ir encoding support

[James Hogan <james.hogan@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

On Sunday 16 February 2014 19:04:01 Antti Seppälä wrote:
> On 12 February 2014 01:39, James Hogan <james.hogan@imgtec.com> wrote:
> > On Tuesday 11 February 2014 20:14:19 Antti Seppälä wrote:
> >> Are you working on the wakeup protocol selector sysfs interface?
> > 
> > I gave it a try yesterday, but it's a bit of a work in progress at the
> > moment. It's also a bit more effort for img-ir to work properly with it,
> > so I'd probably just limit the allowed wakeup protocols to the enabled
> > normal protocol at first in img-ir.
> > 
> > Here's what I have (hopefully kmail won't corrupt it), feel free to take
> > and improve/fix it. I'm not keen on the invasiveness of the
> > allowed_protos/enabled_protocols change (which isn't complete), but it
> > should probably be abstracted at some point anyway.
> 
> In general the approach here looks good. At least I couldn't figure
> any easy way to be less intrusive towards drivers/decoders and still
> support wakeup filters.

Thanks for taking a look (and sorry for the delay getting back to this, 
holiday and sickness got in the way). FYI I've cleaned up my wakeup_protocols 
patches a lot and will probably post tomorrow (after rebasing my patches to 
allow me to test img-ir properly with it).

Cheers
James

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]