From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:56504 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921Ab3HUV5A (ORCPT ); Wed, 21 Aug 2013 17:57:00 -0400 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, ismael.luceno@corp.bluecherry.net, pete@sensoray.com, sylvester.nawrocki@gmail.com, sakari.ailus@iki.fi, Hans Verkuil Subject: Re: [RFCv2 PATCH 09/10] DocBook: document the new v4l2 matrix ioctls. Date: Wed, 21 Aug 2013 23:58:13 +0200 Message-ID: <1527473.WFxGOHRo9q@avalon> In-Reply-To: <1376305113-17128-10-git-send-email-hverkuil@xs4all.nl> References: <1376305113-17128-1-git-send-email-hverkuil@xs4all.nl> <1376305113-17128-10-git-send-email-hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, Thank you for the patch. On Monday 12 August 2013 12:58:32 Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > Documentation/DocBook/media/v4l/v4l2.xml | 2 + > .../DocBook/media/v4l/vidioc-g-matrix.xml | 115 +++++++++++++ > .../DocBook/media/v4l/vidioc-query-matrix.xml | 178 ++++++++++++++++++ > 3 files changed, 295 insertions(+) > create mode 100644 Documentation/DocBook/media/v4l/vidioc-g-matrix.xml > create mode 100644 Documentation/DocBook/media/v4l/vidioc-query-matrix.xml [snip] > diff --git a/Documentation/DocBook/media/v4l/vidioc-query-matrix.xml > b/Documentation/DocBook/media/v4l/vidioc-query-matrix.xml new file mode > 100644 > index 0000000..c2845c7 > --- /dev/null > +++ b/Documentation/DocBook/media/v4l/vidioc-query-matrix.xml > @@ -0,0 +1,178 @@ > + > + > + ioctl VIDIOC_QUERY_MATRIX > + &manvol; > + > + > + > + VIDIOC_QUERY_MATRIX > + Query the attributes of a matrix > + > + > + > + > + > + int ioctl > + int fd > + int request > + struct v4l2_query_matrix > +*argp > + > + > + > + > + > + Arguments > + > + > + > + fd > + > + &fd; > + > + > + > + request > + > + VIDIOC_QUERY_MATRIX > + > + > + > + argp > + > + > + > + > + > + > + > + > + Description > + > + Query the attributes of a matrix. The application fills in the > + type and optionally the > ref > + fields of &v4l2-query-matrix;. All other fields will be returned by the > driver. > + > + > + > + struct <structname>v4l2_query_matrix</structname> > + > + &cs-str; > + > + > + __u32 > + type > + > + Type of the matrix, see />. + > + > + union > + ref > + > + This union makes it possible to identify the object owning the > + matrix. Currently the only defined matrix types are identified > through > + the filehandle used to call the ioctl, so this union isn't used > (yet). > + > + > + __u32 > + columns > + > + Number of columns in the matrix. > + > + > + __u32 > + rows > + > + Number of rows in the matrix. > + > + > + union > + elem_min > + > + > + > + > + > + __s64 > + val > + The minimal signed value of each matrix element. > + > + > + > + __u64 > + uval > + The minimal unsigned value of each matrix > element. > + > + > + union > + elem_max > + > + > + > + > + > + __s64 > + val > + The maximal signed value of each matrix element. > + > + > + > + __u64 > + uval > + The maximal unsigned value of each matrix > element. > + > + > + __u32 > + elem_size > + > + The size in bytes of a single matrix element. > + The full matrix size will be columns * > + rows * > elem_size. > + > + > + __u32 > + reserved[12] > + > + Reserved for future extensions. Drivers must set > + the array to zero. > + > + > + > +
> + > + > + Matrix Types > + > + > + > + > + > + Type > + Description > + > + > + > + > + V4L2_MATRIX_T_MD_REGION > + Hardware motion detection often divides the image into several > + regions, and each region can have its own motion detection > thresholds. > + This matrix assigns a region number to each element. Each element is > a __u8. > + Generally each element refers to a block of pixels in the image. >>From the description I have trouble understanding what the matrix type is for. Do you think we could make the explanation more detailed ? > + > + > + > + V4L2_MATRIX_T_MD_THRESHOLD > + Hardware motion detection can assign motion detection threshold > + values to each element of an image. Each element is a __u16. + > Generally each element refers to a block of pixels in the image. + > > + > + > + > +
> + > + > + > + &return-value; > + > + -- Regards, Laurent Pinchart