From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Steve Longerbeam" <steve_longerbeam@mentor.com>,
"Steve Longerbeam" <slongerbeam@gmail.com>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v2 10/10] media: imx.rst: Update doc to reflect fixes to interlaced capture
Date: Mon, 04 Jun 2018 10:34:54 +0200 [thread overview]
Message-ID: <1528101294.5808.6.camel@pengutronix.de> (raw)
In-Reply-To: <fc9933d7-93d0-1e0c-ca63-70a4f3faf618@mentor.com>
On Sat, 2018-06-02 at 11:44 -0700, Steve Longerbeam wrote:
>
> On 06/01/2018 06:44 AM, Philipp Zabel wrote:
> > On Thu, 2018-05-31 at 17:30 -0700, Steve Longerbeam wrote:
> > <snip>
> > > +
> > > +.. code-block:: none
> > > +
> > > + # Setup links
> > > + media-ctl -l "'adv7180 3-0021':0 -> 'ipu1_csi0_mux':1[1]"
> > > + media-ctl -l "'ipu1_csi0_mux':2 -> 'ipu1_csi0':0[1]"
> > > + media-ctl -l "'ipu1_csi0':2 -> 'ipu1_csi0 capture':0[1]"
> > > + # Configure pads
> > > + media-ctl -V "'adv7180 3-0021':0 [fmt:UYVY2X8/720x480 field:seq-bt]"
> > > + media-ctl -V "'ipu1_csi0_mux':2 [fmt:UYVY2X8/720x480]"
> > > + media-ctl -V "'ipu1_csi0':2 [fmt:AYUV32/720x480 field:interlaced]"
> >
> > Could the example suggest using interlaced-bt to be explicit here?
> > Actually, I don't think we should allow interlaced on the CSI src pads
> > at all in this case. Technically it always writes either seq-tb or seq-
> > bt into the smfc, never interlaced (unless the input is already
> > interlaced).
> >
>
> Hmm, if the sink is 'alternate', and the requested source is
> 'interlaced*', perhaps we should allow the source to be
> 'interlaced*' and not override it. For example, if requested
> is 'interlaced-tb', let it be that. IOW assume user knows something
> we don't about the original field order, or is experimenting
> with finding the correct field order.
If the source material is really interlaced and not alternate, shouldn't
the sink pad be set to interlaced?
regards
Philipp
prev parent reply other threads:[~2018-06-04 8:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 0:30 [PATCH v2 00/10] imx-media: Fixes for interlaced capture Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 01/10] media: imx-csi: Pass sink pad field to ipu_csi_init_interface Steve Longerbeam
2018-06-01 13:22 ` Philipp Zabel
2018-06-02 16:30 ` Steve Longerbeam
2018-06-04 5:25 ` Krzysztof Hałasa
2018-06-04 8:32 ` Philipp Zabel
2018-06-04 16:47 ` Steve Longerbeam
2018-06-05 4:54 ` Krzysztof Hałasa
2018-06-01 0:30 ` [PATCH v2 02/10] gpu: ipu-csi: Check for field type alternate Steve Longerbeam
2018-06-01 13:26 ` Philipp Zabel
2018-06-01 0:30 ` [PATCH v2 03/10] media: videodev2.h: Add macros V4L2_FIELD_IS_{INTERLACED|SEQUENTIAL} Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 04/10] media: imx: interweave only for sequential input/interlaced output fields Steve Longerbeam
2018-06-01 13:33 ` Philipp Zabel
2018-06-02 16:32 ` Steve Longerbeam
2018-06-04 5:35 ` Krzysztof Hałasa
2018-06-04 8:27 ` Philipp Zabel
2018-06-05 0:56 ` Steve Longerbeam
2018-06-05 8:07 ` Philipp Zabel
2018-06-05 10:43 ` Krzysztof Hałasa
2018-06-05 19:00 ` Steve Longerbeam
2018-06-06 5:48 ` Krzysztof Hałasa
2018-06-06 9:05 ` Philipp Zabel
2018-06-07 3:37 ` Steve Longerbeam
2018-06-07 7:43 ` Krzysztof Hałasa
2018-06-06 6:26 ` Krzysztof Hałasa
2018-06-01 0:30 ` [PATCH v2 05/10] media: imx: interweave and odd-chroma-row skip are incompatible Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 06/10] media: imx: Fix field setting logic in try_fmt Steve Longerbeam
2018-06-01 13:34 ` Philipp Zabel
2018-06-02 16:32 ` Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 07/10] media: imx-csi: Allow skipping odd chroma rows for YVU420 Steve Longerbeam
2018-06-01 13:35 ` Philipp Zabel
2018-06-01 0:30 ` [PATCH v2 08/10] media: imx: vdic: rely on VDIC for correct field order Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 09/10] media: imx-csi: Move crop/compose reset after filling default mbus fields Steve Longerbeam
2018-06-01 0:30 ` [PATCH v2 10/10] media: imx.rst: Update doc to reflect fixes to interlaced capture Steve Longerbeam
2018-06-01 13:44 ` Philipp Zabel
2018-06-02 17:58 ` Steve Longerbeam
2018-06-02 18:44 ` Steve Longerbeam
2018-06-04 5:52 ` Krzysztof Hałasa
2018-06-04 8:34 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528101294.5808.6.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=khalasa@piap.pl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox