From: Philipp Zabel <p.zabel@pengutronix.de>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [PATCH] media: coda: add missing h.264 levels
Date: Thu, 19 Jul 2018 12:50:37 +0200 [thread overview]
Message-ID: <1531997437.3755.7.camel@pengutronix.de> (raw)
In-Reply-To: <e35a9f6a-4704-29ad-66c5-b17bc71d18ac@xs4all.nl>
On Thu, 2018-07-19 at 12:39 +0200, Hans Verkuil wrote:
> On 07/19/18 12:32, Philipp Zabel wrote:
> > Hi,
> >
> > On Thu, 2018-06-28 at 13:01 +0200, Philipp Zabel wrote:
> > > This enables reordering support for h.264 main profile level 4.2,
> > > 5.0, and 5.1 streams. Even though we likely can't play back such
> > > streams at full speed, we should still recognize them correctly.
> > >
> > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > ---
> > > drivers/media/platform/coda/coda-h264.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
> > > index 0e27412e01f5..07b4c706504f 100644
> > > --- a/drivers/media/platform/coda/coda-h264.c
> > > +++ b/drivers/media/platform/coda/coda-h264.c
> > > @@ -108,6 +108,9 @@ int coda_h264_level(int level_idc)
> > > case 32: return V4L2_MPEG_VIDEO_H264_LEVEL_3_2;
> > > case 40: return V4L2_MPEG_VIDEO_H264_LEVEL_4_0;
> > > case 41: return V4L2_MPEG_VIDEO_H264_LEVEL_4_1;
> > > + case 42: return V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
> > > + case 50: return V4L2_MPEG_VIDEO_H264_LEVEL_5_0;
> > > + case 51: return V4L2_MPEG_VIDEO_H264_LEVEL_5_1;
> > > default: return -EINVAL;
> > > }
> > > }
> >
> > I've seen that some newer coda patches have been accepted already,
> > maybe this fell through the cracks?
>
> No, this was part of a pull request of mine posted July 6th which hasn't
> been merged yet (Mauro is traveling with poor internet connectivity). I
> think he's back next week, so hopefully we'll see these pull request merged.
Oh, I have to keep a closer look on the pull requests.
I only checked patchwork. Thank you!
regards
Philipp
next prev parent reply other threads:[~2018-07-19 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 11:01 [PATCH] media: coda: add missing h.264 levels Philipp Zabel
2018-07-19 10:32 ` Philipp Zabel
2018-07-19 10:39 ` Hans Verkuil
2018-07-19 10:50 ` Philipp Zabel [this message]
2018-07-19 11:10 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531997437.3755.7.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=hverkuil@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox