From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Stefan Muenzel <stefanmuenzel@googlemail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [media] uvcvideo: Add 10,12bit and alternate 8bit greyscale
Date: Sun, 29 Jul 2012 07:56:56 +0200 [thread overview]
Message-ID: <1537901.D4de3zSszL@avalon> (raw)
In-Reply-To: <1343515754-1043-1-git-send-email-stefanmuenzel@googlemail.com>
Hi Stefan,
Thanks for the patch.
On Saturday 28 July 2012 18:49:14 Stefan Muenzel wrote:
> Some cameras support 10bit and 12bit greyscale, or use the alternate "Y8
> " FOURCC for 8bit greyscale. Add support for these.
Could you please tell me which camera(s) use those formats ?
> Tested on a 12bit camera.
>
> Signed-off-by: Stefan Muenzel <stefanmuenzel@googlemail.com>
> ---
> drivers/media/video/uvc/uvc_driver.c | 19 +++++++++++++++++--
> drivers/media/video/uvc/uvcvideo.h | 9 +++++++++
> 2 files changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/uvc/uvc_driver.c
> b/drivers/media/video/uvc/uvc_driver.c index 1d13172..11db262 100644
> --- a/drivers/media/video/uvc/uvc_driver.c
> +++ b/drivers/media/video/uvc/uvc_driver.c
> @@ -95,12 +95,27 @@ static struct uvc_format_desc uvc_fmts[] = {
> .fcc = V4L2_PIX_FMT_UYVY,
> },
> {
> - .name = "Greyscale (8-bit)",
> + .name = "Greyscale 8-bit (Y800)",
> .guid = UVC_GUID_FORMAT_Y800,
> .fcc = V4L2_PIX_FMT_GREY,
> },
> {
> - .name = "Greyscale (16-bit)",
> + .name = "Greyscale 8-bit (Y8 )",
> + .guid = UVC_GUID_FORMAT_Y8,
> + .fcc = V4L2_PIX_FMT_GREY,
> + },
> + {
> + .name = "Greyscale 10-bit (Y10 )",
> + .guid = UVC_GUID_FORMAT_Y10,
> + .fcc = V4L2_PIX_FMT_Y10,
> + },
> + {
> + .name = "Greyscale 12-bit (Y12 )",
> + .guid = UVC_GUID_FORMAT_Y12,
> + .fcc = V4L2_PIX_FMT_Y12,
> + },
> + {
> + .name = "Greyscale 16-bit (Y16 )",
> .guid = UVC_GUID_FORMAT_Y16,
> .fcc = V4L2_PIX_FMT_Y16,
> },
> diff --git a/drivers/media/video/uvc/uvcvideo.h
> b/drivers/media/video/uvc/uvcvideo.h index 7c3d082..3764040 100644
> --- a/drivers/media/video/uvc/uvcvideo.h
> +++ b/drivers/media/video/uvc/uvcvideo.h
> @@ -79,6 +79,15 @@
> #define UVC_GUID_FORMAT_Y800 \
> { 'Y', '8', '0', '0', 0x00, 0x00, 0x10, 0x00, \
> 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +#define UVC_GUID_FORMAT_Y8 \
> + { 'Y', '8', ' ', ' ', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +#define UVC_GUID_FORMAT_Y10 \
> + { 'Y', '1', '0', ' ', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +#define UVC_GUID_FORMAT_Y12 \
> + { 'Y', '1', '2', ' ', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> #define UVC_GUID_FORMAT_Y16 \
> { 'Y', '1', '6', ' ', 0x00, 0x00, 0x10, 0x00, \
> 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2012-07-29 5:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 22:49 [PATCH 1/1] [media] uvcvideo: Add 10,12bit and alternate 8bit greyscale Stefan Muenzel
2012-07-29 5:56 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537901.D4de3zSszL@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=stefanmuenzel@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox