From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-media@vger.kernel.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
Matt Ranostay <matt.ranostay@konsulko.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hansverk@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: [PATCH v4 3/6] media: v4l2-common: add V4L2_FRACT_COMPARE
Date: Sat, 20 Oct 2018 23:26:25 +0900 [thread overview]
Message-ID: <1540045588-9091-4-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1540045588-9091-1-git-send-email-akinobu.mita@gmail.com>
Add macro to compare two v4l2_fract values in v4l2 common internal API.
The same macro FRACT_CMP() is used by vivid and bcm2835-camera. This just
renames it to V4L2_FRACT_COMPARE in order to avoid namespace collision.
Cc: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Hans Verkuil <hansverk@cisco.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
* v4
- No changes from v3
include/media/v4l2-common.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
index cdc87ec..eafb8a3 100644
--- a/include/media/v4l2-common.h
+++ b/include/media/v4l2-common.h
@@ -384,4 +384,9 @@ int v4l2_g_parm_cap(struct video_device *vdev,
int v4l2_s_parm_cap(struct video_device *vdev,
struct v4l2_subdev *sd, struct v4l2_streamparm *a);
+/* Compare two v4l2_fract structs */
+#define V4L2_FRACT_COMPARE(a, OP, b) \
+ ((u64)(a).numerator * (b).denominator OP \
+ (u64)(b).numerator * (a).denominator)
+
#endif /* V4L2_COMMON_H_ */
--
2.7.4
next prev parent reply other threads:[~2018-10-20 22:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 14:26 [PATCH v4 0/6] media: video-i2c: support changing frame interval and runtime PM Akinobu Mita
2018-10-20 14:26 ` [PATCH v4 1/6] media: video-i2c: avoid accessing released memory area when removing driver Akinobu Mita
2018-10-20 20:23 ` Sakari Ailus
2018-10-20 14:26 ` [PATCH v4 2/6] media: video-i2c: use i2c regmap Akinobu Mita
2018-10-20 14:26 ` Akinobu Mita [this message]
2018-10-28 3:48 ` [PATCH v4 3/6] media: v4l2-common: add V4L2_FRACT_COMPARE Matt Ranostay
2018-10-28 16:25 ` Akinobu Mita
2018-10-28 17:09 ` Matt Ranostay
2018-10-20 14:26 ` [PATCH v4 4/6] media: vivid: use V4L2_FRACT_COMPARE Akinobu Mita
2018-10-20 14:26 ` [PATCH v4 5/6] media: video-i2c: support changing frame interval Akinobu Mita
2018-10-28 3:39 ` Matt Ranostay
2018-10-28 16:21 ` Akinobu Mita
2018-10-20 14:26 ` [PATCH v4 6/6] media: video-i2c: support runtime PM Akinobu Mita
2018-11-19 14:26 ` Hans Verkuil
2018-11-19 14:59 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540045588-9091-4-git-send-email-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=hansverk@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).