[PATCH] media: v4l: v4l2-controls.h must include types.h

[PATCH] media: v4l: v4l2-controls.h must include types.h

[Jean Delvare]

Fix the following build-time warning:
./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without #include <linux/types.h>

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: c27bb30e7b6d ("media: v4l: Add definitions for MPEG-2 slice format and metadata")
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 include/uapi/linux/v4l2-controls.h |    2 ++
 1 file changed, 2 insertions(+)

--- linux-4.20-rc2.orig/include/uapi/linux/v4l2-controls.h	2018-11-12 09:34:20.869048454 +0100
+++ linux-4.20-rc2/include/uapi/linux/v4l2-controls.h	2018-11-12 10:54:38.864904194 +0100
@@ -50,6 +50,8 @@
 #ifndef __LINUX_V4L2_CONTROLS_H
 #define __LINUX_V4L2_CONTROLS_H
 
+#include <linux/types.h>		/* for __u* typedefs */
+
 /* Control classes */
 #define V4L2_CTRL_CLASS_USER		0x00980000	/* Old-style 'user' controls */
 #define V4L2_CTRL_CLASS_MPEG		0x00990000	/* MPEG-compression controls */


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] media: v4l: v4l2-controls.h must include types.h

[Paul Kocialkowski]

[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]

Hi,

On Mon, 2018-11-12 at 11:01 +0100, Jean Delvare wrote:
> Fix the following build-time warning:
> ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without #include <linux/types.h>

We already have a similar fix in the media tree:
https://git.linuxtv.org/media_tree.git/commit/?h=request_api&id=dafb7f9aef2fd44991ff1691721ff765a23be27b

So it looks like we won't be needing this one!

Cheers,

Paul

> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Fixes: c27bb30e7b6d ("media: v4l: Add definitions for MPEG-2 slice format and metadata")
> Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  include/uapi/linux/v4l2-controls.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-4.20-rc2.orig/include/uapi/linux/v4l2-controls.h	2018-11-12 09:34:20.869048454 +0100
> +++ linux-4.20-rc2/include/uapi/linux/v4l2-controls.h	2018-11-12 10:54:38.864904194 +0100
> @@ -50,6 +50,8 @@
>  #ifndef __LINUX_V4L2_CONTROLS_H
>  #define __LINUX_V4L2_CONTROLS_H
>  
> +#include <linux/types.h>		/* for __u* typedefs */
> +
>  /* Control classes */
>  #define V4L2_CTRL_CLASS_USER		0x00980000	/* Old-style 'user' controls */
>  #define V4L2_CTRL_CLASS_MPEG		0x00990000	/* MPEG-compression controls */
> 
> 
-- 
Paul Kocialkowski, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] media: v4l: v4l2-controls.h must include types.h

[Jean Delvare]

On Mon, 2018-11-12 at 11:03 +0100, Paul Kocialkowski wrote:
> On Mon, 2018-11-12 at 11:01 +0100, Jean Delvare wrote:
> > Fix the following build-time warning:
> > ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without #include <linux/types.h>
> 
> We already have a similar fix in the media tree:
> https://git.linuxtv.org/media_tree.git/commit/?h=request_api&id=dafb7f9aef2fd44991ff1691721ff765a23be27b
> 
> So it looks like we won't be needing this one!

Perfect, thanks for letting me know and sorry for the noise.

-- 
Jean Delvare
SUSE L3 Support