Re: [PATCH 2/2] media: imx355: fix wrong order in test pattern menus

Bingbu Cao
2018-11-27T13:36:27Z

On 11/26/2018 04:57 PM, Sakari Ailus wrote:
> Hi Bing Bu,
>
> On Mon, Nov 26, 2018 at 03:43:34PM +0800, bingbu.cao@intel.com wrote:
>> From: Bingbu Cao <bingbu.cao@intel.com>
>>
>> current imx355 test pattern order in ctrl menu
>> is not correct, this patch fixes it.
>>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
>> ---
>> drivers/media/i2c/imx355.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
>> index 20c8eea5db4b..9c9559dfd3dd 100644
>> --- a/drivers/media/i2c/imx355.c
>> +++ b/drivers/media/i2c/imx355.c
>> @@ -876,8 +876,8 @@ struct imx355 {
>>
>> static const char * const imx355_test_pattern_menu[] = {
>> "Disabled",
>> - "100% color bars",
>> "Solid color",
>> + "100% color bars",
>> "Fade to gray color bars",
>> "PN9"
>> };
> While at it, could you use the existing test pattern naming as well for the
> drivers? That could be a separate patch.
>
> >From drivers/media/i2c/smiapp/smiapp-core.c :
>
> static const char * const smiapp_test_patterns[] = {
> "Disabled",
> "Solid Colour",
> "Eight Vertical Colour Bars",
> "Colour Bars With Fade to Grey",
> "Pseudorandom Sequence (PN9)",
> };
>
> It's not strictly necessary from interface point of view, but for the user
> space it'd be good to align the naming.
Sakari, ask a question that not really related to this patch.
I am wondering whether there are some standardization for the camera sensor
pattern generator.
Currently there are varied patterns and every vendor has its own pattern types.
>