From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:57451 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753434AbdJMMlu (ORCPT ); Fri, 13 Oct 2017 08:41:50 -0400 From: Laurent Pinchart To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Jonathan Corbet , Mauro Carvalho Chehab , Linux Doc Mailing List Subject: Re: [PATCH v2 12/17] media: v4l2-fwnode.h: better describe bus union at fwnode endpoint struct Date: Fri, 13 Oct 2017 15:42:03 +0300 Message-ID: <1543874.t5QE87S79G@avalon> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Mauro, Thank you for the patch. On Thursday, 28 September 2017 00:46:55 EEST Mauro Carvalho Chehab wrote: > Now that kernel-doc handles nested unions, better document the > bus union at struct v4l2_fwnode_endpoint. > > Signed-off-by: Mauro Carvalho Chehab > --- > include/media/v4l2-fwnode.h | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h > index 7adec9851d9e..5f4716f967d0 100644 > --- a/include/media/v4l2-fwnode.h > +++ b/include/media/v4l2-fwnode.h > @@ -79,7 +79,18 @@ struct v4l2_fwnode_bus_mipi_csi1 { > * struct v4l2_fwnode_endpoint - the endpoint data structure > * @base: fwnode endpoint of the v4l2_fwnode > * @bus_type: bus type > - * @bus: bus configuration data structure > + * @bus: union with bus configuration data structure > + * @bus.parallel: pointer for &struct v4l2_fwnode_bus_parallel. > + * Used if the bus is parallel. > + * @bus.mipi_csi1: pointer for &struct v4l2_fwnode_bus_mipi_csi1. > + * Used if the bus is Mobile Industry Processor > + * Interface's Camera Serial Interface version 1 > + * (MIPI CSI1) or Standard Mobile Imaging Architecture's > + * Compact Camera Port 2 (SMIA CCP2). > + * @bus.mipi_csi2: pointer for &struct v4l2_fwnode_bus_mipi_csi2. > + * Used if the bus is Mobile Industry Processor > + * Interface's Camera Serial Interface version 2 > + * (MIPI CSI2). These are not pointers. > * @link_frequencies: array of supported link frequencies > * @nr_of_link_frequencies: number of elements in link_frequenccies array > */ -- Regards, Laurent Pinchart