From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:57553 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbcIIImi (ORCPT ); Fri, 9 Sep 2016 04:42:38 -0400 From: Laurent Pinchart To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Hans Verkuil , Antti Palosaari , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil , Ezequiel Garcia Subject: Re: [PATCH] [media] usb: constify vb2_ops structures Date: Fri, 09 Sep 2016 11:43:12 +0300 Message-ID: <1549816.Lv63yEq5Dv@avalon> In-Reply-To: <1473379141-17286-1-git-send-email-Julia.Lawall@lip6.fr> References: <1473379141-17286-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Julia, Thank you for the patch. On Friday 09 Sep 2016 01:59:01 Julia Lawall wrote: > Check for vb2_ops structures that are only stored in the ops field of a > vb2_queue structure. That field is declared const, so vb2_ops structures > that have this property can be declared as const also. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct vb2_ops i@p = { ... }; > > @ok@ > identifier r.i; > struct vb2_queue e; > position p; > @@ > e.ops = &i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct vb2_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct vb2_ops i = { ... }; > // > > Signed-off-by: Julia Lawall For > drivers/media/usb/uvc/uvc_queue.c | 2 +- Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart