From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB8BC48BD7 for ; Thu, 27 Jun 2019 12:56:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 558C02085A for ; Thu, 27 Jun 2019 12:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726465AbfF0M4R (ORCPT ); Thu, 27 Jun 2019 08:56:17 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:47713 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfF0M4R (ORCPT ); Thu, 27 Jun 2019 08:56:17 -0400 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1hgTwk-0004EC-3z; Thu, 27 Jun 2019 14:56:14 +0200 Message-ID: <1561640172.4216.16.camel@pengutronix.de> Subject: Re: [PATCH] media: imx: mipi csi-2: Don't fail if initial state times-out From: Philipp Zabel To: Fabio Estevam Cc: Steve Longerbeam , Ezequiel Garcia , Laurent Pinchart , kernel@collabora.com, Shawn Guo , Sascha Hauer , linux-media , Hans Verkuil , Nicolas Dufresne Date: Thu, 27 Jun 2019 14:56:12 +0200 In-Reply-To: References: <20190625203945.28081-1-ezequiel@collabora.com> <1561535121.4870.1.camel@pengutronix.de> <3797cdd2-f6c8-f23d-788c-b8efc3e75b21@gmail.com> <1561624997.4216.11.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Fabio, On Thu, 2019-06-27 at 09:38 -0300, Fabio Estevam wrote: > Hi Philipp, > > On Thu, Jun 27, 2019 at 5:43 AM Philipp Zabel wrote: > > > Are there any visual artifacts in the first frame(s) in this case? > > I do not observe visual artifacts when running gst-launch-1.0 v4l2src ! kmssink > > > > So in my opinion the next version of this patch should make LP-11 > > > timeout a warning only, but keep the error return on clock lane timeouts. > > > > I agree. > > Here is a reworked version of Ezequiel's patch as per the suggestions: > http://code.bulix.org/g5qap5-780475 > > Does this one look good? Limiting the change to wait_stopstate is fine, the actual message makes assumptions that could be misleading. How about: "Timeout waiting for LP-11 state on all active lanes. This is most likely caused by a bug in the sensor driver. Capture might fail or contain visual artifacts." I'd like to keep the phy_state register output though, if only as dev_dbg(). It contains useful output for debugging, for example if only some of the lanes are in stop state, which could indicate an issue with connections or lane configuration. regards Philipp