From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Andreas Bombe <aeb@debian.org>
Cc: linux-media@vger.kernel.org
Subject: Re: [media-ctl PATCH] Add missing stdlib.h and ctype.h includes
Date: Mon, 25 Mar 2013 23:05:07 +0100 [thread overview]
Message-ID: <1566926.cSFf0o3dIQ@avalon> (raw)
In-Reply-To: <20130218001244.GA7932@amos.fritz.box>
Hi Andreas,
Thanks for the patch, and sorry for the late reply.
On Monday 18 February 2013 01:12:44 Andreas Bombe wrote:
> src/mediactl.c needs ctype.h for its use of isspace().
>
> src/v4l2subdev.c needs stdlib.h for strtoul() and ctype.h for isspace()
> and isupper().
>
> Signed-off-by: Andreas Bombe <aeb@debian.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and pushed to the repository.
> ---
> src/mediactl.c | 1 +
> src/v4l2subdev.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/src/mediactl.c b/src/mediactl.c
> index 46562de..c2f985a 100644
> --- a/src/mediactl.c
> +++ b/src/mediactl.c
> @@ -29,6 +29,7 @@
> #include <stdbool.h>
> #include <stdio.h>
> #include <stdlib.h>
> +#include <ctype.h>
> #include <string.h>
> #include <fcntl.h>
> #include <errno.h>
> diff --git a/src/v4l2subdev.c b/src/v4l2subdev.c
> index d0c37f3..87d7eb7 100644
> --- a/src/v4l2subdev.c
> +++ b/src/v4l2subdev.c
> @@ -26,6 +26,8 @@
> #include <errno.h>
> #include <fcntl.h>
> #include <stdbool.h>
> +#include <stdlib.h>
> +#include <ctype.h>
> #include <stdio.h>
> #include <string.h>
> #include <unistd.h>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2013-03-25 22:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 0:12 [media-ctl PATCH] Add missing stdlib.h and ctype.h includes Andreas Bombe
2013-03-25 22:05 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566926.cSFf0o3dIQ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=aeb@debian.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox