From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC23CC388C1 for ; Thu, 5 Sep 2019 14:20:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70C3A222C0 for ; Thu, 5 Sep 2019 14:14:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730477AbfIEOOT (ORCPT ); Thu, 5 Sep 2019 10:14:19 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:31898 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726048AbfIEOOT (ORCPT ); Thu, 5 Sep 2019 10:14:19 -0400 X-UUID: 2f11ff7d98724b569e3e90e98073f37c-20190905 X-UUID: 2f11ff7d98724b569e3e90e98073f37c-20190905 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 742702825; Thu, 05 Sep 2019 22:14:14 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Sep 2019 22:14:10 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 5 Sep 2019 22:14:10 +0800 Message-ID: <1567692852.22453.55.camel@mtksdccf07> Subject: Re: [RFC PATCH V2 3/4] media: platform: Add Mediatek FD driver KConfig From: Jerry-ch Chen To: Laurent Pinchart CC: "hans.verkuil@cisco.com" , "laurent.pinchart+renesas@ideasonboard.com" , "tfiga@chromium.org" , "matthias.bgg@gmail.com" , "mchehab@kernel.org" , "yuzhao@chromium.org" , "zwisler@chromium.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , "Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?=" , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Rynn Wu =?UTF-8?Q?=28=E5=90=B3=E8=82=B2=E6=81=A9=29?= , Po-Yang Huang =?UTF-8?Q?=28=E9=BB=83=E6=9F=8F=E9=99=BD=29?= , "shik@chromium.org" , "suleiman@chromium.org" , "linux-media@vger.kernel.org" , srv_heupstream , "devicetree@vger.kernel.org" Date: Thu, 5 Sep 2019 22:14:12 +0800 In-Reply-To: <20190905123054.GL5035@pendragon.ideasonboard.com> References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-4-git-send-email-Jerry-Ch.chen@mediatek.com> <20190905123054.GL5035@pendragon.ideasonboard.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Laurent, On Thu, 2019-09-05 at 20:30 +0800, Laurent Pinchart wrote: > Hi Jerry, > > Thank you for the patch. > > On Tue, Jul 09, 2019 at 04:41:11PM +0800, Jerry-ch Chen wrote: > > From: Jerry-ch Chen > > > > This patch adds KConfig for Mediatek Face Detection driver (FD). > > FD is embedded in Mediatek SoCs. It can provide hardware > > accelerated face detection function. > > > > Signed-off-by: Jerry-ch Chen > > You can squash this patch with 4/4, there's no need to keep it separate. > I appreciate your comments, Ok, I will squash it. > > --- > > drivers/media/platform/Kconfig | 2 ++ > > drivers/media/platform/mtk-isp/fd/Kconfig | 17 +++++++++++++++++ > > 2 files changed, 19 insertions(+) > > create mode 100644 drivers/media/platform/mtk-isp/fd/Kconfig > > > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index a505e9f..ae99258e 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -32,6 +32,8 @@ source "drivers/media/platform/davinci/Kconfig" > > > > source "drivers/media/platform/omap/Kconfig" > > > > +source "drivers/media/platform/mtk-isp/fd/Kconfig" > > + > > config VIDEO_ASPEED > > tristate "Aspeed AST2400 and AST2500 Video Engine driver" > > depends on VIDEO_V4L2 > > diff --git a/drivers/media/platform/mtk-isp/fd/Kconfig b/drivers/media/platform/mtk-isp/fd/Kconfig > > new file mode 100644 > > index 0000000..0c5eaf0 > > --- /dev/null > > +++ b/drivers/media/platform/mtk-isp/fd/Kconfig > > @@ -0,0 +1,17 @@ > > +config VIDEO_MEDIATEK_FD > > + bool "Mediatek face detection processing function" > > + select DMA_SHARED_BUFFER > > + select VIDEOBUF2_DMA_CONTIG > > + select VIDEOBUF2_CORE > > + select VIDEOBUF2_V4L2 > > + select VIDEOBUF2_MEMOPS > > + select VIDEOBUF2_VMALLOC > > Do you need both VIDEOBUF2_DMA_CONTIG and VIDEOBUF2_VMALLOC ? The driver > doesn't seem to make use of VIDEOBUF2_VMALLOC. > No, I should remove it. and also would like to update as following: depends on VIDEO_V4L2 depends on ARCH_MEDIATEK || COMPILE_TEST select VIDEOBUF2_DMA_CONTIG select VIDEOBUF2_CORE select VIDEOBUF2_V4L2 select VIDEOBUF2_MEMOPS select MEDIA_CONTROLLER select MTK_SCP > > + select MEDIA_CONTROLLER > > + > > + default n > > + help > > + Support the Face Detectioin (FD) feature. > > s/Detectioin/Detection/ > Typo fixed. > Maybe "... feature found in the Mediatek SoCs." ? I will refine as: Support the Face Detection (FD) feature in the Mediatek mt8183 Soc. Thanks and best regards, Jerry > > > + > > + FD driver is a V4L2 memory-to-memory device driver which > > + provides hardware accelerated face detection function, > > + it can detect different sizes of faces in a raw image. >