From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 629BDC49ED7 for ; Mon, 16 Sep 2019 05:33:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A72520644 for ; Mon, 16 Sep 2019 05:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729114AbfIPFdb (ORCPT ); Mon, 16 Sep 2019 01:33:31 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:58486 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725826AbfIPFdb (ORCPT ); Mon, 16 Sep 2019 01:33:31 -0400 X-UUID: be81d0a7727d42c4844085990551010f-20190916 X-UUID: be81d0a7727d42c4844085990551010f-20190916 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1726329568; Mon, 16 Sep 2019 13:33:23 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 16 Sep 2019 13:33:22 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 16 Sep 2019 13:33:22 +0800 Message-ID: <1568612002.14078.1.camel@mtksdaap41> Subject: Re: [RFC PATCH V4 3/4] dt-bindings: mt8183: Add sensor interface dt-bindings From: Yingjoe Chen To: Louis Kuo CC: , , , , , , , , , , , , , , , , , , , Date: Mon, 16 Sep 2019 13:33:22 +0800 In-Reply-To: <20190915065004.20257-4-louis.kuo@mediatek.com> References: <20190915065004.20257-1-louis.kuo@mediatek.com> <20190915065004.20257-4-louis.kuo@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sun, 2019-09-15 at 14:50 +0800, Louis Kuo wrote: > This patch adds the DT binding documentation for the sensor interface > module in Mediatek SoCs. > > Signed-off-by: Louis Kuo > --- > .../bindings/media/mediatek-seninf.txt | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek-seninf.txt > > diff --git a/Documentation/devicetree/bindings/media/mediatek-seninf.txt b/Documentation/devicetree/bindings/media/mediatek-seninf.txt > new file mode 100644 > index 000000000000..bf2eb801cb47 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek-seninf.txt > @@ -0,0 +1,30 @@ > +* Mediatek seninf MIPI-CSI2 host driver > + > +Seninf MIPI-CSI2 host driver is a HW camera interface controller. It support a widely adopted, > +simple, high-speed protocol primarily intended for point-to-point image and video > +transmission between cameras and host devices. > + > +Required properties: > + - compatible: "mediatek,mt8183-seninf" > + - reg: Must contain an entry for each entry in reg-names. > + - reg-names: Must include the following entries: > + "base_reg": seninf registers base > + "rx_reg": Rx analog registers base Everyone here is a reg. Adding _reg prefix for everyone looks redundant. Same for clock-names. > + - interrupts: interrupt number to the cpu. > + - clocks : clock name from clock manager > + - clock-names: must be CLK_CAM_SENINF and CLK_TOP_MUX_SENINF. > + It is the clocks of seninf > + Joe.C