From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: John Weber <rjohnweber@gmail.com>, linux-media@vger.kernel.org
Subject: Re: Using omap3-isp-live example application on beagleboard with DVI
Date: Fri, 19 Oct 2012 16:01 +0200 [thread overview]
Message-ID: <1584362.BsWDphDTBL@avalon> (raw)
In-Reply-To: <CAFqH_53G_jt1LdTiHtqnGKkqK8mmCOgt-ypQzpzjwpdytpsgzQ@mail.gmail.com>
Hi Enric,
On Wednesday 17 October 2012 11:35:37 Enric Balletbo Serra wrote:
> 2012/10/17 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
[snip]
> > Instead of failing what would be more interesting would be to get the
> > application to work in 16bpp mode as well. For that you will need to paint
> > the frame buffer with a 16bpp color, and set the colorkey to the same
> > value. Would you be able to try that ?
>
> New patch attached, comments are welcome as I'm newbie with video devices.
Thank you for the patch. In the future could you please send patches inline
instead of attached (git send-email is a very useful tool for that) ? It would
make review easier.
You can get the bpp value directly from the frame buffer API without going
through sysfs. I've modified your patch accordingly, have added support for
24bpp as well and pushed the result to the repository.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-10-19 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 16:43 Using omap3-isp-live example application on beagleboard with DVI John Weber
2012-10-10 13:24 ` Enric Balletbò i Serra
2012-10-11 8:14 ` Enric Balletbò i Serra
2012-10-11 21:56 ` Laurent Pinchart
2012-10-15 12:03 ` Enric Balletbo Serra
2012-10-17 0:21 ` Laurent Pinchart
2012-10-17 9:35 ` Enric Balletbo Serra
2012-10-19 14:01 ` Laurent Pinchart [this message]
2012-10-19 17:25 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584362.BsWDphDTBL@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=eballetbo@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=rjohnweber@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).