Re: [PATCH] V4L: fix ov9650 control clusters

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Guennadi,

Thank you for the patch.

On Tuesday 19 January 2016 12:12:48 Guennadi Liakhovetski wrote:
> Auto-gain and auto-exposure clusters in the ov9650 driver have both a
> size of 2, not 3 controls. Fix this.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I'd change the subject to "v4l: ov9650: Fix control clusters" though.

> ---
>  drivers/media/i2c/ov9650.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
> index 9fe9006..2baa528 100644
> --- a/drivers/media/i2c/ov9650.c
> +++ b/drivers/media/i2c/ov9650.c
> @@ -1046,8 +1046,8 @@ static int ov965x_initialize_controls(struct ov965x
> *ov965x) ctrls->exposure->flags |= V4L2_CTRL_FLAG_VOLATILE;
> 
>  	v4l2_ctrl_auto_cluster(3, &ctrls->auto_wb, 0, false);
> -	v4l2_ctrl_auto_cluster(3, &ctrls->auto_gain, 0, true);
> -	v4l2_ctrl_auto_cluster(3, &ctrls->auto_exp, 1, true);
> +	v4l2_ctrl_auto_cluster(2, &ctrls->auto_gain, 0, true);
> +	v4l2_ctrl_auto_cluster(2, &ctrls->auto_exp, 1, true);
>  	v4l2_ctrl_cluster(2, &ctrls->hflip);
> 
>  	ov965x->sd.ctrl_handler = hdl;

-- 
Regards,

Laurent Pinchart