From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:34878 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932645AbeGINCQ (ORCPT ); Mon, 9 Jul 2018 09:02:16 -0400 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, Hans Verkuil Subject: Re: [PATCHv5 07/12] media.h: reorder video en/decoder functions Date: Mon, 09 Jul 2018 16:02:49 +0300 Message-ID: <1634280.zYXzp3WPWZ@avalon> In-Reply-To: <20180629114331.7617-8-hverkuil@xs4all.nl> References: <20180629114331.7617-1-hverkuil@xs4all.nl> <20180629114331.7617-8-hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, Thank you for the patch. On Friday, 29 June 2018 14:43:26 EEST Hans Verkuil wrote: > From: Hans Verkuil > > Keep the function defines in numerical order: 0x6000 comes after > 0x2000, so move it back. > > Signed-off-by: Hans Verkuil Reviewed-by: Laurent Pinchart > --- > include/uapi/linux/media.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 6f594fa238c2..76d9bd64c116 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -89,13 +89,6 @@ struct media_device_info { > #define MEDIA_ENT_F_FLASH (MEDIA_ENT_F_OLD_SUBDEV_BASE + 2) > #define MEDIA_ENT_F_LENS (MEDIA_ENT_F_OLD_SUBDEV_BASE + 3) > > -/* > - * Video decoder/encoder functions > - */ > -#define MEDIA_ENT_F_ATV_DECODER (MEDIA_ENT_F_OLD_SUBDEV_BASE + 4) > -#define MEDIA_ENT_F_DV_DECODER (MEDIA_ENT_F_BASE + 0x6001) > -#define MEDIA_ENT_F_DV_ENCODER (MEDIA_ENT_F_BASE + 0x6002) > - > /* > * Digital TV, analog TV, radio and/or software defined radio tuner > functions. * > @@ -140,6 +133,13 @@ struct media_device_info { > #define MEDIA_ENT_F_VID_MUX (MEDIA_ENT_F_BASE + 0x5001) > #define MEDIA_ENT_F_VID_IF_BRIDGE (MEDIA_ENT_F_BASE + 0x5002) > > +/* > + * Video decoder/encoder functions > + */ > +#define MEDIA_ENT_F_ATV_DECODER (MEDIA_ENT_F_OLD_SUBDEV_BASE + 4) > +#define MEDIA_ENT_F_DV_DECODER (MEDIA_ENT_F_BASE + 0x6001) > +#define MEDIA_ENT_F_DV_ENCODER (MEDIA_ENT_F_BASE + 0x6002) > + > /* Entity flags */ > #define MEDIA_ENT_FL_DEFAULT (1 << 0) > #define MEDIA_ENT_FL_CONNECTOR (1 << 1) -- Regards, Laurent Pinchart