From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.kundenserver.de ([217.72.192.74]:56528 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753446AbcKUOQM (ORCPT ); Mon, 21 Nov 2016 09:16:12 -0500 From: Arnd Bergmann To: Kevin Hilman Cc: linux-media@vger.kernel.org, Hans Verkuil , devicetree@vger.kernel.org, Sekhar Nori , Axel Haslam , Bartosz =?utf-8?B?R2/FgmFzemV3c2tp?= , Alexandre Bailon , David Lechner , Rob Herring Subject: Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation Date: Mon, 21 Nov 2016 15:15:07 +0100 Message-ID: <165090919.oFnaNnsijv@wuerfel> In-Reply-To: <20161119003208.10550-4-khilman@baylibre.com> References: <20161119003208.10550-1-khilman@baylibre.com> <20161119003208.10550-4-khilman@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: On Friday, November 18, 2016 4:32:08 PM CET Kevin Hilman wrote: > + > +Required properties: > +- compatible: must be "ti,vpif-capture" > +- reg: physical base address and length of the registers set for the device; > +- interrupts: should contain IRQ line for the VPIF > + > Shouldn't this have a SoC specific identifier or a version number in the compatible string? "vpif" seems rather generic, so it's likely that TI made more than one variant of it. Arnd