From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:56462 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdGRJJf (ORCPT ); Tue, 18 Jul 2017 05:09:35 -0400 From: Laurent Pinchart To: Sakari Ailus Cc: pavel@ucw.cz, linux-media@vger.kernel.org Subject: Re: [PATCH 4/7] omap3isp: Return -EPROBE_DEFER if the required regulators can't be obtained Date: Tue, 18 Jul 2017 12:09:42 +0300 Message-ID: <1652763.9EYemjAvaH@avalon> In-Reply-To: <20170717220116.17886-5-sakari.ailus@linux.intel.com> References: <20170717220116.17886-1-sakari.ailus@linux.intel.com> <20170717220116.17886-5-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thank you for the patch. On Tuesday 18 Jul 2017 01:01:13 Sakari Ailus wrote: > From: Pavel Machek > > If regulator returns -EPROBE_DEFER, we need to return it too, so that > omap3isp will be re-probed when regulator is ready. > > Signed-off-by: Pavel Machek > Reviewed-by: Laurent Pinchart > Signed-off-by: Sakari Ailus > --- > drivers/media/platform/omap3isp/isp.c | 3 ++- > drivers/media/platform/omap3isp/ispccp2.c | 5 +++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index 80ed5a5f862a..4e6ba7f90e35 > 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -1880,7 +1880,8 @@ static int isp_initialize_modules(struct isp_device > *isp) > > ret = omap3isp_ccp2_init(isp); > if (ret < 0) { > - dev_err(isp->dev, "CCP2 initialization failed\n"); > + if (ret != -EPROBE_DEFER) > + dev_err(isp->dev, "CCP2 initialization failed\n"); > goto error_ccp2; > } > > diff --git a/drivers/media/platform/omap3isp/ispccp2.c > b/drivers/media/platform/omap3isp/ispccp2.c index > 4f8fd0c00748..47210b102bcb 100644 > --- a/drivers/media/platform/omap3isp/ispccp2.c > +++ b/drivers/media/platform/omap3isp/ispccp2.c > @@ -1140,6 +1140,11 @@ int omap3isp_ccp2_init(struct isp_device *isp) > if (isp->revision == ISP_REVISION_2_0) { > ccp2->vdds_csib = devm_regulator_get(isp->dev, "vdds_csib"); > if (IS_ERR(ccp2->vdds_csib)) { > + if (PTR_ERR(ccp2->vdds_csib) == -EPROBE_DEFER) { > + dev_dbg(isp->dev, > + "Can't get regulator vdds_csib, deferring probing\n"); > + return -EPROBE_DEFER; > + } > dev_dbg(isp->dev, > "Could not get regulator vdds_csib\n"); I would just move this message above the -EPROBE_DEFER check and remove the one inside the check. Probe deferral debug information can be obtained by enabling the debug messages in the driver core. > ccp2->vdds_csib = NULL; -- Regards, Laurent Pinchart