From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B426C43217 for ; Thu, 19 May 2022 18:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243507AbiESSBs (ORCPT ); Thu, 19 May 2022 14:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243498AbiESSBq (ORCPT ); Thu, 19 May 2022 14:01:46 -0400 Received: from smtp1.de.adit-jv.com (smtp1.de.adit-jv.com [93.241.18.167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E6275A14F; Thu, 19 May 2022 11:01:44 -0700 (PDT) Received: from hi2exch02.adit-jv.com (hi2exch02.adit-jv.com [10.72.92.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id 5ECC73C00BA; Thu, 19 May 2022 20:01:42 +0200 (CEST) Received: from vmlxhi-121.localdomain (10.72.92.132) by hi2exch02.adit-jv.com (10.72.92.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 20:01:42 +0200 From: Michael Rodin To: Mauro Carvalho Chehab , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , , , CC: Michael Rodin , , Subject: Improve error handling in the rcar-vin driver Date: Thu, 19 May 2022 20:00:06 +0200 Message-ID: <1652983210-1194-1-git-send-email-mrodin@de.adit-jv.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.72.92.132] X-ClientProxiedBy: hi2exch02.adit-jv.com (10.72.92.28) To hi2exch02.adit-jv.com (10.72.92.28) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello, this series is a followup to the other series [1] started by Niklas Söderlund where only the first patch has been merged. The overall idea is to be more compliant with the Renesas hardware manual which requires a reset or stop of capture in the VIN module before reset of CSI2. Another goal (achieved by the patch 3/3) is to be more resilient with respect to non-critical CSI2 errors so the driver does not end in an endless restart loop. Patch 1/3 has been taken from [1] with some additional documentation changes. Patch 2/3 is included without any changes. Patch 3/3 is based on discussions in [2], where I also found one method to trigger CSI2 errors in the video pipeline on a Salvator board for testing by manipulating CSI2-related registers in the adv7482: $ i2cset -f -y 4 0x64 0x00 0x04 $ i2cset -f -y 4 0x64 0x00 0x24 [1] https://lore.kernel.org/linux-renesas-soc/20211108160220.767586-1-niklas.soderlund+renesas@ragnatech.se/ [2] https://lore.kernel.org/linux-renesas-soc/20220309192707.GA62903@vmlxhi-121.adit-jv.com/