From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503E8C433EF for ; Fri, 17 Jun 2022 07:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbiFQHFy (ORCPT ); Fri, 17 Jun 2022 03:05:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380114AbiFQHFx (ORCPT ); Fri, 17 Jun 2022 03:05:53 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF1C60D9D for ; Fri, 17 Jun 2022 00:05:53 -0700 (PDT) Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2EA9E268; Fri, 17 Jun 2022 09:05:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1655449551; bh=HN7A+5zHFMXk55nwXzancx5aMhenLkLPL0C1loQOviI=; h=In-Reply-To:References:Subject:From:To:Date:From; b=b5MoTC1HIlf6N05L0pj15L7XeL06BFBd0nXXh6oEFq5SgrETfJUkdduYAA2z2rx8y oyYMV+TgzVibT5B+7iMtthd/dZuYTd0GrxsjT112qd9Vl3UTD65gDeSTtRzp0Pyg68 9GCbz2zmQD3Y+xllYVH38l/spMtxklI7ySu4bz80= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <9ea3155a-5099-e02d-3707-06b89395f8d1@linuxfoundation.org> References: <20220616100747.48124-1-daniel.oakley@ideasonboard.com> <20220616100747.48124-2-daniel.oakley@ideasonboard.com> <02e4de58-9de7-56e7-d673-6c01f50da64b@linuxfoundation.org> <165541466600.2786155.16126381340154209662@Monstersaurus> <9ea3155a-5099-e02d-3707-06b89395f8d1@linuxfoundation.org> Subject: Re: [PATCH 1/3] media: vimc: expand the names of vimc entity types From: Kieran Bingham To: Daniel Oakley , Mauro Carvalho Chehab , Shuah Khan , linux-media@vger.kernel.org Date: Fri, 17 Jun 2022 08:05:48 +0100 Message-ID: <165544954869.2786155.786044635537343355@Monstersaurus> User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Quoting Shuah Khan (2022-06-16 22:57:36) > On 6/16/22 3:24 PM, Kieran Bingham wrote: > > Quoting Shuah Khan (2022-06-16 15:41:45) > >> On 6/16/22 8:29 AM, Shuah Khan wrote: > >>> On 6/16/22 4:07 AM, Daniel Oakley wrote: > >>>> When introducing the lens controller, it became apparent that the vi= mc > >>>> entity type names were hard to understand, e.g. vimc_len_type refers= to the > >>>> lens. The names of the vimc entity types have been expanded to make = the > >>>> code easier to understand. There is no functional change intended. > >>>> > >>>> Suggested-by: Kieran Bingham > >>>> Signed-off-by: Daniel Oakley > >>>> --- > >>>> =C2=A0 .../media/test-drivers/vimc/vimc-capture.c=C2=A0=C2=A0=C2=A0= | 270 ++++++------ > >>>> =C2=A0 drivers/media/test-drivers/vimc/vimc-common.h |=C2=A0 10 +- > >>>> =C2=A0 drivers/media/test-drivers/vimc/vimc-core.c=C2=A0=C2=A0 |=C2= =A0 22 +- > >>>> =C2=A0 .../media/test-drivers/vimc/vimc-debayer.c=C2=A0=C2=A0=C2=A0= | 393 +++++++++--------- > >>>> =C2=A0 drivers/media/test-drivers/vimc/vimc-lens.c=C2=A0=C2=A0 |=C2= =A0 82 ++-- > >>>> =C2=A0 drivers/media/test-drivers/vimc/vimc-scaler.c | 216 +++++---= -- > >>>> =C2=A0 drivers/media/test-drivers/vimc/vimc-sensor.c | 307 +++++++-= ------ > >>>> =C2=A0 7 files changed, 652 insertions(+), 648 deletions(-) > >>>> > >>> > >>> Thank you for the patch to improve code readability. Looks good to me. > >>> > >>> Reviewed-by: Shuah Khan > >>> > >> > >> > >> Reviewed all three patches > >> > >> Mauro, > >> > >> Would you like me to send a pull request for these patches? > >=20 > > Hi Shuah, > >=20 > > Please note that I believe these patches are based on top of Yunke's not > > yet accepted patches for the vimc-lens. > >=20 >=20 > Yes. I am aware of that. I will make sure they are applied in the right > order. >=20 Aha, perfect, thanks - I had missed that you had already reviewed Yunke's patches before this. -- Kieran > thanks, > -- Shuah >