From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCHv2 4/6] uvc gadget: switch to unlocked_ioctl.
Date: Tue, 17 Feb 2015 22:51:23 +0200 [thread overview]
Message-ID: <1662021.9djB0xorDl@avalon> (raw)
In-Reply-To: <1424162649-17249-5-git-send-email-hverkuil@xs4all.nl>
Hi Hans,
Thank you for the patch.
On Tuesday 17 February 2015 09:44:07 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Instead of .ioctl use unlocked_ioctl. This allows us to finally remove
> the old .ioctl op.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/usb/gadget/function/uvc_v4l2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/uvc_v4l2.c
> b/drivers/usb/gadget/function/uvc_v4l2.c index 0bd6965..5a84e51 100644
> --- a/drivers/usb/gadget/function/uvc_v4l2.c
> +++ b/drivers/usb/gadget/function/uvc_v4l2.c
> @@ -357,7 +357,7 @@ struct v4l2_file_operations uvc_v4l2_fops = {
> .owner = THIS_MODULE,
> .open = uvc_v4l2_open,
> .release = uvc_v4l2_release,
> - .ioctl = video_ioctl2,
> + .unlocked_ioctl = video_ioctl2,
> .mmap = uvc_v4l2_mmap,
> .poll = uvc_v4l2_poll,
> #ifndef CONFIG_MMU
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-02-17 20:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 8:44 [PATCHv2 0/6] Remove .ioctl from v4l2_file_operations Hans Verkuil
2015-02-17 8:44 ` [PATCHv2 1/6] pvrusb2: replace .ioctl by .unlocked_ioctl Hans Verkuil
2015-02-17 8:44 ` [PATCHv2 2/6] radio-bcm2048: use unlocked_ioctl instead of ioctl Hans Verkuil
2015-02-17 8:44 ` [PATCHv2 3/6] uvc gadget: switch to v4l2 core locking Hans Verkuil
2015-02-17 20:51 ` Laurent Pinchart
2015-02-17 8:44 ` [PATCHv2 4/6] uvc gadget: switch to unlocked_ioctl Hans Verkuil
2015-02-17 20:51 ` Laurent Pinchart [this message]
2015-02-17 8:44 ` [PATCHv2 5/6] uvc gadget: set device_caps in querycap Hans Verkuil
2015-02-17 8:44 ` [PATCHv2 6/6] v4l2-core: remove the old .ioctl BKL replacement Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1662021.9djB0xorDl@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox