From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:50242 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbcLIPU4 (ORCPT ); Fri, 9 Dec 2016 10:20:56 -0500 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se Subject: Re: [PATCH v2 9/9] davinci: Use a local media device pointer instead Date: Fri, 09 Dec 2016 17:21:23 +0200 Message-ID: <1662555.iXAvrS7ZxI@avalon> In-Reply-To: <1481295222-14743-10-git-send-email-sakari.ailus@linux.intel.com> References: <1481295222-14743-1-git-send-email-sakari.ailus@linux.intel.com> <1481295222-14743-10-git-send-email-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thank you for the patch. On Friday 09 Dec 2016 16:53:42 Sakari Ailus wrote: > The function has a local variable that points to the media device; use > that instead of finding the media device under the entity. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/staging/media/davinci_vpfe/vpfe_video.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c > b/drivers/staging/media/davinci_vpfe/vpfe_video.c index 03269d3..8b2117e > 100644 > --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c > +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c > @@ -145,7 +145,7 @@ static int vpfe_prepare_pipeline(struct > vpfe_video_device *video) pipe->outputs[pipe->output_num++] = video; > > mutex_lock(&mdev->graph_mutex); > - ret = media_graph_walk_init(&graph, entity->graph_obj.mdev); > + ret = media_graph_walk_init(&graph, mdev); > if (ret) { > mutex_unlock(&mdev->graph_mutex); > return -ENOMEM; > @@ -300,7 +300,7 @@ static int vpfe_pipeline_enable(struct vpfe_pipeline > *pipe) > > mdev = entity->graph_obj.mdev; > mutex_lock(&mdev->graph_mutex); > - ret = media_graph_walk_init(&pipe->graph, entity->graph_obj.mdev); > + ret = media_graph_walk_init(&pipe->graph, mdev); > if (ret) > goto out; > media_graph_walk_start(&pipe->graph, entity); -- Regards, Laurent Pinchart