From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:42836 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752730AbcAJPaH (ORCPT ); Sun, 10 Jan 2016 10:30:07 -0500 From: Laurent Pinchart To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , linux-api@vger.kernel.org Subject: Re: [PATCH] [media] media.h: let be clear that tuners need to use connectors Date: Sun, 10 Jan 2016 17:30:15 +0200 Message-ID: <1667088.5VvxRK5I9C@avalon> In-Reply-To: <16cd172bc9cec7ce438df95c142d2219998e32fe.1449867690.git.mchehab@osg.samsung.com> References: <16cd172bc9cec7ce438df95c142d2219998e32fe.1449867690.git.mchehab@osg.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Mauro, Thank you for the patch. On Friday 11 December 2015 19:01:31 Mauro Carvalho Chehab wrote: > The V4L2 core won't be adding connectors to the tuners and other > entities that need them. Let it be clear. > > Suggested-by: Laurent Pinchart > Signed-off-by: Mauro Carvalho Chehab > --- > include/uapi/linux/media.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 86f9753e5c03..cacfceb0d81d 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -74,10 +74,11 @@ struct media_device_info { > /* > * Connectors > */ > +/* It is a responsibility of the entity drivers to add connectors and links Do you mean entity drivers or "master/bridge" (for lack of a better word) drivers ? I don't think it should be the responsibility of the tuner driver to create connectors, as the tuner driver shouldn't know about the entities surrounding it. > */ #define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 21) > #define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 22) > #define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 23) > - /* For internal test signal generators and other debug connectors */ > +/* For internal test signal generators and other debug connectors */ > #define MEDIA_ENT_F_CONN_TEST (MEDIA_ENT_F_BASE + 24) > > /* > @@ -105,6 +106,10 @@ struct media_device_info { > #define MEDIA_ENT_F_FLASH (MEDIA_ENT_F_OLD_SUBDEV_BASE + 2) > #define MEDIA_ENT_F_LENS (MEDIA_ENT_F_OLD_SUBDEV_BASE + 3) > #define MEDIA_ENT_F_ATV_DECODER (MEDIA_ENT_F_OLD_SUBDEV_BASE + 4) > +/* > + * It is a responsibility of the entity drivers to add connectors and links > + * for the tuner entities. > + */ > #define MEDIA_ENT_F_TUNER (MEDIA_ENT_F_OLD_SUBDEV_BASE + 5) > > #define MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN MEDIA_ENT_F_OLD_SUBDEV_BASE -- Regards, Laurent Pinchart