Re: [PATCH for v3.17 1/2] videobuf2-core.h: fix comment

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Hans,

Thank you for the patch.

On Monday 04 August 2014 12:27:11 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
> 
> The comment for start_streaming that tells the developer with which vb2
> state buffers should be returned to vb2 gave the wrong state. Very
> confusing.
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I wonder whether we couldn't simplify drivers by moving this into vb2 though. 
A failed start_streaming requires drivers to dequeue all buffers internally, 
but the call to vb2_buffer_done() could be handled inside vb2. On the other 
hand it would make the vb2 warning go away, and drivers that fail to dequeue 
buffers internally would not be caught as easily, so I won't push for that 
change.

> ---
>  include/media/videobuf2-core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
> index fc910a6..80fa725 100644
> --- a/include/media/videobuf2-core.h
> +++ b/include/media/videobuf2-core.h
> @@ -295,7 +295,7 @@ struct vb2_buffer {
>   *			can return an error if hardware fails, in that case all
>   *			buffers that have been already given by the @buf_queue
>   *			callback are to be returned by the driver by calling
> - *			@vb2_buffer_done(VB2_BUF_STATE_DEQUEUED).
> + *			@vb2_buffer_done(VB2_BUF_STATE_QUEUED).
>   *			If you need a minimum number of buffers before you can
>   *			start streaming, then set @min_buffers_needed in the
>   *			vb2_queue structure. If that is non-zero then

-- 
Regards,

Laurent Pinchart