From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] smiapp: Use better regulator name for the Device tree
Date: Fri, 09 May 2014 14:16:47 +0200 [thread overview]
Message-ID: <1688439.tqIRKfgIXZ@avalon> (raw)
In-Reply-To: <1399163517-5220-2-git-send-email-sakari.ailus@iki.fi>
Hi Sakari,
Thank you for the patch.
On Sunday 04 May 2014 03:31:55 Sakari Ailus wrote:
> Rename "VANA" regulator as "vana".
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
> b/drivers/media/i2c/smiapp/smiapp-core.c index 8741cae..c1d6d1d 100644
> --- a/drivers/media/i2c/smiapp/smiapp-core.c
> +++ b/drivers/media/i2c/smiapp/smiapp-core.c
> @@ -2355,7 +2355,7 @@ static int smiapp_registered(struct v4l2_subdev
> *subdev) unsigned int i;
> int rval;
>
> - sensor->vana = devm_regulator_get(&client->dev, "VANA");
> + sensor->vana = devm_regulator_get(&client->dev, "vana");
> if (IS_ERR(sensor->vana)) {
> dev_err(&client->dev, "could not get regulator for vana\n");
> return -ENODEV;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-05-09 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 0:31 smiapp: Minor improvements, early preparation for DT support Sakari Ailus
2014-05-04 0:31 ` [PATCH 1/3] smiapp: Use better regulator name for the Device tree Sakari Ailus
2014-05-09 12:16 ` Laurent Pinchart [this message]
2014-05-04 0:31 ` [PATCH 2/3] smiapp: Check for GPIO validity using gpio_is_valid() Sakari Ailus
2014-05-09 12:18 ` Laurent Pinchart
2014-05-09 12:38 ` Sakari Ailus
2014-05-04 0:31 ` [PATCH 3/3] smiapp: Return correct return value in smiapp_registered() Sakari Ailus
2014-05-09 12:17 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1688439.tqIRKfgIXZ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox