Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Scott,

On Thursday 28 March 2013 16:29:30 Scott Jiang wrote:
> >> This driver support parallel data output mode and
> >> QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565
> >> output format.
> > 
> > What host bridge do you use this driver with ?
> 
> I only tested with blackfin.
> 
> >> + */
> > 
> > [snip]
> > 
> >> +struct mt9m114_reg {
> >> +     u16 reg;
> >> +     u32 val;
> >> +     int width;
> >> +};
> >> +
> >> +enum {
> >> +     MT9M114_QVGA,
> >> +     MT9M114_VGA,
> >> +     MT9M114_WVGA,
> >> +     MT9M114_720P,
> >> +};
> > 
> > This is the part I don't like. Instead of hardcoding 4 different
> > resolutions and using large register address/value tables, you should
> > compute the register values from the image size requested by the user.
> 
> In fact we get this table with the Aptina development tool. So we only
> support fixed resolutions. If we compute each register value, it only makes
> the code more complex.

But it also makes the code more useful, as the user won't be limited to the 4 
resolutions above.

-- 
Regards,

Laurent Pinchart