From: Rob Herring <robh@kernel.org>
To: Sean Young <sean@mess.org>
Cc: "Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Sicelo <absicsz@gmail.com>, "Tony Lindgren" <tony@atomide.com>,
linux-media@vger.kernel.org, "Pavel Machek" <pavel@ucw.cz>,
devicetree@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Timo Kokkonen" <timo.t.kokkonen@iki.fi>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v3 2/2] media: dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible
Date: Tue, 22 Aug 2023 10:15:44 -0500 [thread overview]
Message-ID: <169271734434.205322.10925215324069905304.robh@kernel.org> (raw)
In-Reply-To: <20230822145644.213589-3-sean@mess.org>
On Tue, 22 Aug 2023 15:56:44 +0100, Sean Young wrote:
> The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir
> can be removed.
>
> Cc: Sicelo <absicsz@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Cc: Pali Rohár <pali.rohar@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Timo Kokkonen <timo.t.kokkonen@iki.fi>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Sean Young <sean@mess.org>
> ---
> .../bindings/leds/irled/pwm-ir-tx.yaml | 4 +++-
> .../devicetree/bindings/media/nokia,n900-ir | 20 -------------------
> 2 files changed, 3 insertions(+), 21 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Traceback (most recent call last):
File "/usr/local/bin/dt-doc-validate", line 64, in <module>
ret |= check_doc(f)
^^^^^^^^^^^^
File "/usr/local/bin/dt-doc-validate", line 32, in check_doc
for error in sorted(dtsch.iter_errors(), key=lambda e: e.linecol):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/dtschema/schema.py", line 135, in iter_errors
self.annotate_error(scherr, meta_schema, scherr.schema_path)
File "/usr/local/lib/python3.11/dist-packages/dtschema/schema.py", line 114, in annotate_error
schema = schema[p]
~~~~~~^^^
KeyError: 'type'
Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.example.dtb: /example-0/irled: failed to match any schema with compatible: ['pwm-ir-tx']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230822145644.213589-3-sean@mess.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-08-22 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 14:56 [PATCH v2 0/2] Remove ir-rx51 driver Sean Young
2023-08-22 14:56 ` [PATCH v3 1/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx Sean Young
2023-09-06 15:58 ` Uwe Kleine-König
2023-09-06 16:03 ` Sean Young
2023-08-22 14:56 ` [PATCH v3 2/2] media: dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible Sean Young
2023-08-22 15:15 ` Rob Herring [this message]
2023-08-22 15:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169271734434.205322.10925215324069905304.robh@kernel.org \
--to=robh@kernel.org \
--cc=absicsz@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
--cc=timo.t.kokkonen@iki.fi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox