Re: [PATCH 6/6] experimental: arm: dts: dra7xx: Add a DT node for VPE

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Archit,

Thank you for the patch.

On Friday 02 August 2013 19:33:43 Archit Taneja wrote:
> Add a DT node for VPE in dra7.dtsi. This is experimental because we might
> need to split the VPE address space a bit more, and also because the IRQ
> line described is accessible the IRQ crossbar driver is added for DRA7XX.
> 
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Sricharan R <r.sricharan@ti.com>
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++

Documentation is missing :-) As this is an experimental patch you can probably 
document the bindings later.

>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index ce9a0f0..3237972 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -484,6 +484,17 @@
>  			dmas = <&sdma 70>, <&sdma 71>;
>  			dma-names = "tx0", "rx0";
>  		};
> +
> +		vpe {
> +			compatible = "ti,vpe";
> +			ti,hwmods = "vpe";
> +			reg = <0x489d0000 0xd000>, <0x489dd000 0x400>;
> +			reg-names = "vpe", "vpdma";
> +			interrupts = <0 159 0x4>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;

Are #address-cells and #size-cells really needed ?

> +		};
> +
>  	};
> 
>  	clocks {
-- 
Regards,

Laurent Pinchart