Re: [PATCH v2] media: synopsys: hdmirx: Detect broken interrupt

[Dmitry Osipenko <dmitry.osipenko@collabora.com>]

On 10/2/25 18:33, Sebastian Reichel wrote:
> Hello Dmitry,
> 
> On Thu, Oct 02, 2025 at 05:07:50PM +0300, Dmitry Osipenko wrote:
>> Downstream version of RK3588 U-Boot uses customized TF-A that remaps
>> HDMIRX hardware interrupt, routing it via firmware that isn't supported
>> by upstream driver.
>>
>> Detect broken interrupt and print a clarifying error message about a need
>> to use open-source TF-A with this driver.
>>
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> ---
>> Changelog:
>>
>> v2: - Added PHY r/w lock and moved the clarifying error message as
>>       was suggested by Sebastian Reichel.
>>
>>  .../platform/synopsys/hdmirx/snps_hdmirx.c    | 90 ++++++++++++++++++-
>>  .../platform/synopsys/hdmirx/snps_hdmirx.h    |  2 +
>>  2 files changed, 90 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> index b7d278b3889f..e6456352dfa5 100644
>> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> 
> #include <linux/cleanup.h>
> 
> Otherwise LGTM and hopefully helps people to figure out the root
> cause of their problems:
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Thanks for the review. The cleanup.h always included by mutex/spinlock
headers, there is no need to include it explicitly.


-- 
Best regards,
Dmitry