From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Lisa Nguyen <lisa@xenapiadmin.com>
Cc: prabhakar.csengg@gmail.com,
davinci-linux-open-source@linux.davincidsp.com,
linux-media@vger.kernel.org, m.chehab@samsung.com
Subject: Re: [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c
Date: Wed, 11 Dec 2013 13:02:48 +0100 [thread overview]
Message-ID: <1716044.mWq9ph1Vrl@avalon> (raw)
In-Reply-To: <20131211060921.GA4772@ubuntu>
Hi Lisa,
Thank you for the patch.
On Tuesday 10 December 2013 22:09:22 Lisa Nguyen wrote:
> Rewrite the return statement in vpfe_video.c. This will prevent
> the checkpatch.pl script from generating a warning saying
> to remove () from this particular return statement.
>
> Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Acked-by; Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v3:
> - Removed () from return statement per Laurent Pinchart's suggestion
>
> drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> b/drivers/staging/media/davinci_vpfe/vpfe_video.c index 24d98a6..3b036be
> 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> @@ -346,7 +346,7 @@ static int vpfe_pipeline_disable(struct vpfe_pipeline
> *pipe) }
> mutex_unlock(&mdev->graph_mutex);
>
> - return (ret == 0) ? ret : -ETIMEDOUT ;
> + return ret ? -ETIMEDOUT : 0;
> }
>
> /*
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-12-11 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 6:09 [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c Lisa Nguyen
2013-12-11 12:02 ` Laurent Pinchart [this message]
2013-12-11 16:57 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1716044.mWq9ph1Vrl@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-media@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=m.chehab@samsung.com \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox