* [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c
@ 2013-12-11 6:09 Lisa Nguyen
2013-12-11 12:02 ` Laurent Pinchart
2013-12-11 16:57 ` Prabhakar Lad
0 siblings, 2 replies; 3+ messages in thread
From: Lisa Nguyen @ 2013-12-11 6:09 UTC (permalink / raw)
To: prabhakar.csengg
Cc: davinci-linux-open-source, linux-media, m.chehab,
laurent.pinchart
Rewrite the return statement in vpfe_video.c. This will prevent
the checkpatch.pl script from generating a warning saying
to remove () from this particular return statement.
Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
---
Changes since v3:
- Removed () from return statement per Laurent Pinchart's suggestion
drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
index 24d98a6..3b036be 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
@@ -346,7 +346,7 @@ static int vpfe_pipeline_disable(struct vpfe_pipeline *pipe)
}
mutex_unlock(&mdev->graph_mutex);
- return (ret == 0) ? ret : -ETIMEDOUT ;
+ return ret ? -ETIMEDOUT : 0;
}
/*
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c
2013-12-11 6:09 [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c Lisa Nguyen
@ 2013-12-11 12:02 ` Laurent Pinchart
2013-12-11 16:57 ` Prabhakar Lad
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2013-12-11 12:02 UTC (permalink / raw)
To: Lisa Nguyen
Cc: prabhakar.csengg, davinci-linux-open-source, linux-media,
m.chehab
Hi Lisa,
Thank you for the patch.
On Tuesday 10 December 2013 22:09:22 Lisa Nguyen wrote:
> Rewrite the return statement in vpfe_video.c. This will prevent
> the checkpatch.pl script from generating a warning saying
> to remove () from this particular return statement.
>
> Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Acked-by; Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v3:
> - Removed () from return statement per Laurent Pinchart's suggestion
>
> drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> b/drivers/staging/media/davinci_vpfe/vpfe_video.c index 24d98a6..3b036be
> 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> @@ -346,7 +346,7 @@ static int vpfe_pipeline_disable(struct vpfe_pipeline
> *pipe) }
> mutex_unlock(&mdev->graph_mutex);
>
> - return (ret == 0) ? ret : -ETIMEDOUT ;
> + return ret ? -ETIMEDOUT : 0;
> }
>
> /*
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c
2013-12-11 6:09 [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c Lisa Nguyen
2013-12-11 12:02 ` Laurent Pinchart
@ 2013-12-11 16:57 ` Prabhakar Lad
1 sibling, 0 replies; 3+ messages in thread
From: Prabhakar Lad @ 2013-12-11 16:57 UTC (permalink / raw)
To: Lisa Nguyen; +Cc: dlos, linux-media, Mauro Carvalho Chehab, Laurent Pinchart
Hi Lisa,
Thanks for the patch.
On Wed, Dec 11, 2013 at 11:39 AM, Lisa Nguyen <lisa@xenapiadmin.com> wrote:
> Rewrite the return statement in vpfe_video.c. This will prevent
> the checkpatch.pl script from generating a warning saying
> to remove () from this particular return statement.
>
> Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Will be queueing it for 3.14.
Regrads,
--Prabhakar Lad
> ---
> Changes since v3:
> - Removed () from return statement per Laurent Pinchart's suggestion
>
> drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> index 24d98a6..3b036be 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> @@ -346,7 +346,7 @@ static int vpfe_pipeline_disable(struct vpfe_pipeline *pipe)
> }
> mutex_unlock(&mdev->graph_mutex);
>
> - return (ret == 0) ? ret : -ETIMEDOUT ;
> + return ret ? -ETIMEDOUT : 0;
> }
>
> /*
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-11 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-11 6:09 [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c Lisa Nguyen
2013-12-11 12:02 ` Laurent Pinchart
2013-12-11 16:57 ` Prabhakar Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox