From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:39506 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753743AbbDGOiR (ORCPT ); Tue, 7 Apr 2015 10:38:17 -0400 From: Laurent Pinchart To: Russell King - ARM Linux Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org, Mauro Carvalho Chehab , sakari.ailus@iki.fi Subject: Re: [PATCH 07/14] media: omap3isp: remove unused clkdev Date: Tue, 07 Apr 2015 17:38:41 +0300 Message-ID: <1734484.Zgs1aYnH8A@avalon> In-Reply-To: <20150407124536.GK4027@n2100.arm.linux.org.uk> References: <20150403171149.GC13898@n2100.arm.linux.org.uk> <1894989.AGoQvgsks0@avalon> <20150407124536.GK4027@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Russell, On Tuesday 07 April 2015 13:45:36 Russell King - ARM Linux wrote: > On Tue, Apr 07, 2015 at 12:42:52PM +0300, Laurent Pinchart wrote: > > On Sunday 05 April 2015 15:20:34 Russell King - ARM Linux wrote: > > > On Sat, Apr 04, 2015 at 12:44:35AM +0300, Laurent Pinchart wrote: > > > > Hi Russell, > > > > > > > > Thank you for the patch; > > > > > > > > On Friday 03 April 2015 18:12:58 Russell King wrote: > > > > > No merged platform supplies xclks via platform data. As we want to > > > > > slightly change the clkdev interface, rather than fixing this unused > > > > > code, remove it instead. > > > > > > > > > > Signed-off-by: Russell King > > > > > > > > Acked-by: Laurent Pinchart > > > > > > > > with one caveat though : it conflicts with patches queued for v4.1 in > > > > the media tree. I'll post a rebased version in a reply to your e-mail. > > > > How would you like to handle the conflict ? > > > > > > How bad is the conflict? > > > > It's not too bad, it's mostly a context-related conflict. There are two > > additional lines to remove (plus the associated comment) from > > isp_xclk_init(), as your patch makes a loop now terminate with if > > (condition) continue;. Those two lines could be removed later, keeping > > them doesn't break anything. > > I think it's fine to take it through the media tree as the series doesn't > have any dependencies on this patch. It was merely attempting to get rid > of stuff so that we could move closer to clkdev dealing with a clk_hw > rather than a struct clk - but I never made it that far with the series. > Maybe at a later date... :) :-) I'll take the patch and send a pull request. -- Regards, Laurent Pinchart