From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2197BC433DB for ; Fri, 15 Jan 2021 23:53:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1D1C2371F for ; Fri, 15 Jan 2021 23:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726607AbhAOXxD (ORCPT ); Fri, 15 Jan 2021 18:53:03 -0500 Received: from gloria.sntech.de ([185.11.138.130]:32942 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726176AbhAOXxD (ORCPT ); Fri, 15 Jan 2021 18:53:03 -0500 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0Yt8-0001TD-QC; Sat, 16 Jan 2021 00:52:18 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: helen.koike@collabora.com, linux-media@vger.kernel.org, mchehab@kernel.org, Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl, Dafna Hirschfeld Cc: linux-rockchip@lists.infradead.org, ezequiel@collabora.com, christoph.muellner@theobroma-systems.com, tfiga@chromium.org Subject: Re: [PATCH v4 3/3] media: rockchip: rkisp1: extend uapi array sizes Date: Sat, 16 Jan 2021 00:52:17 +0100 Message-ID: <1739328.QCnGb9OGeP@diego> In-Reply-To: <6a1a7cb2-7c37-6cbc-43e7-45e5b0b80e21@collabora.com> References: <20210115163829.217131-1-heiko@sntech.de> <20210115163829.217131-4-heiko@sntech.de> <6a1a7cb2-7c37-6cbc-43e7-45e5b0b80e21@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Dafna, Am Freitag, 15. Januar 2021, 18:41:06 CET schrieb Dafna Hirschfeld: > > Am 15.01.21 um 17:38 schrieb Heiko Stuebner: > > From: Heiko Stuebner > > > > Later variants of the rkisp1 block use more entries in some arrays: > > > > RKISP1_CIF_ISP_AE_MEAN_MAX 25 -> 81 > > RKISP1_CIF_ISP_HIST_BIN_N_MAX 16 -> 32 > > RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES 17 -> 34 > > RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 28 -> 81 > > I see you didn't change the value for that define. In the below patch I find @@ -103,7 +111,9 @@ * Histogram calculation */ /* Last 3 values unused. */ -#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 28 +#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10 28 +#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V12 81 +#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V12 so I'm not sure I understand what you mean except this. > The usage of it is a bit more complicated. > It is used in function rkisp1_hst_config. Yeah, though the for-loop iterates over 4*7 entry values, so stays below the RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10 in all cases. > Actually the real number of weight values are 25 (5x5) for rk3399, > the last 3 are not used. I think that in order to support both > 5x5 and 9x9 the code in rkisp1-params.c should change. I'll > send a patch fixing it. If you look at my V12-patch [0] the weight handling is done different there and from the registers, it looks like they exchanges that part of the isp. [0] https://lore.kernel.org/linux-media/20210108193311.3423236-11-heiko@sntech.de/ void rkisp1_hst_config_v12() as a search term [...] > > @@ -862,8 +898,16 @@ struct rkisp1_cif_isp_af_stat { > > * > > * @hist_bins: measured bin counters > > * > > - * Measurement window divided into 16 sub-windows, set > > - * with ISP_HIST_XXX > > + * Measurement window divided into 16 sub-windows for V10/V10 > > + * and 32 sub-windows for V12/V13, set with ISP_HIST_XXX > > It is actually not windows but histogram bins. Could you change it to: > "The histogram values divided into 16 bins for V10/V11 and 32 bins > for V12/V13. It is configured within the struct rkisp1_cif_isp_hst_config. I've changed this like your suggestions and will give a bit of time for the stuff above. But I guess I can send a v5 some time tomorrow? Thanks for your input Heiko