Re: [PATCH 0/1] S3C244X/S3C64XX SoC camera host interface driver

[Tomasz Figa <tomasz.figa@gmail.com>]

On Saturday 11 of August 2012 21:32:15 Sylwester Nawrocki wrote:
> On 08/11/2012 08:39 PM, Tomasz Figa wrote:
> > Hi,
> > 
> > On Saturday 11 of August 2012 20:06:13 Sylwester Nawrocki wrote:
> >> Hi all,
> >> 
> >> This patch adds a driver for Samsung S3C244X/S3C64XX SoC series camera
> >> host interface. My intention was to create a V4L2 driver that would
> >> work
> >> with standard applications like Gstreamer or mplayer, and yet exposing
> >> possibly all features available in the hardware.
> >> 
> >> It took me several weeks to do this work in my (limited) spare time.
> >> Finally I've got something that is functional and I think might be
> >> useful for others, so I'm publishing this initial version. It
> >> hopefully doesn't need much tweaking or corrections, at least as far
> >> as S3C244X is concerned. It has not been tested on S3C64XX SoCs, as I
> >> don't have the hardware. However, the driver has been designed with
> >> covering S3C64XX as well in mind, and I've already taken care of some
> >> differences between S3C2444X and S3C64XX. Mem-to-mem features are not
> >> yet supported, but these are quite separate issue and could be easily
> >> added as a next step.> 
> > I will try to test it on S3C6410 in some reasonably near future and
> > report any needed corrections.
> 
> Sounds great, thanks.

I have not tested the driver yet, but I am looking through the code and it 
seems like S3C6410 (at least according to the documentation) supports far 
more pixel formats than defined in the driver.

Both preview and scaler paths are supposed to support 420/422 planar, 422 
interleaved and 565/666/888 formats.

Also two distinct planar 420 formats exist that simply differ by plane 
order YUV420 (currently supported in your driver) and YVU420 (with Cb and 
Cr planes swapped). It should be pretty straightforward to add support for 
the latter.

Best regards,
Tomasz Figa

> 
> > Currently I am using a modified s5p-fimc driver in my project, but it
> > supports only the codec path of S3C64xx and any needed stream
> > duplication and rescaling is done in later processing, so it might be
> > wise to migrate to yours.
> 
> Yeah, the s3c camif is quite different from the s5p one. Thus the
> s3c-camif driver might be a much better starting point for S3C6410. I
> could test any changes for s3c6410 back on s3c2440 and incorporate the
> verified ones into some common stable git branch.
> 
> --
> 
> Regards,
> Sylwester