Re: [PATCH 1/1] omap3isp: Fix async notifier registration order

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thank you for the patch.

On Wednesday 20 May 2015 01:41:43 Sebastian Reichel wrote:
> Hi Sakari,
> 
> On Wed, May 20, 2015 at 02:08:05AM +0300, Sakari Ailus wrote:
> > The async notifier was registered before the v4l2_device was registered
> > and before the notifier callbacks were set. This could lead to missing the
> > bound() and complete() callbacks and to attempting to spin_lock() and
> > uninitialised spin lock.
> > 
> > Also fix unregistering the async notifier in the case of an error --- the
> > function may not fail anymore after the notifier is registered.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
> 
> I already noticed this during my Camera for N900 work and solved it
> the same way, so:
> 
> Reviewed-By: Sebastian Reichel <sre@kernel.org>
> 
> You may want to add a Fixes Tag against the patch implementing the
> async notifier support in omap3isp, since its quite easy to run into
> the callback problems (at least I did) and the missing resource
> freeing (due to EPROBE_AGAIN).

Applied to my tree with the Reviewed-by and Fixes tags.

-- 
Regards,

Laurent Pinchart