From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:47909 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755406Ab3JCVx5 (ORCPT ); Thu, 3 Oct 2013 17:53:57 -0400 Received: from avalon.localnet (191.Red-2-143-34.dynamicIP.rima-tde.net [2.143.34.191]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ED9BC35A47 for ; Thu, 3 Oct 2013 23:53:25 +0200 (CEST) From: Laurent Pinchart To: linux-media@vger.kernel.org Subject: Re: [PATCH] v4l2-fh: Add forward declaration for struct file Date: Thu, 03 Oct 2013 23:54:02 +0200 Message-ID: <1753722.grHNBxjFLq@avalon> In-Reply-To: <1380836936-20914-1-git-send-email-laurent.pinchart@ideasonboard.com> References: <1380836936-20914-1-git-send-email-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: On Thursday 03 October 2013 23:48:56 Laurent Pinchart wrote: > Pointers to struct file are used as function arguments, but the > structure isn't declared. Add a forward declaration. Scratch this, I've sent the patch too soon. struct file is dereferenced in v4l2-fh.h, it does need to be properly defined. I'll send the correct patch. Sorry for the noise. > Signed-off-by: Laurent Pinchart > --- > include/media/v4l2-fh.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/media/v4l2-fh.h b/include/media/v4l2-fh.h > index a62ee18..76aeec7 100644 > --- a/include/media/v4l2-fh.h > +++ b/include/media/v4l2-fh.h > @@ -28,6 +28,7 @@ > > #include > > +struct file; > struct video_device; > struct v4l2_ctrl_handler; -- Regards, Laurent Pinchart