Re: [PATCH 10/25] media: dw100: Drop unneeded v4l2_m2m_get_vq() NULL check

[Stefan Klug <stefan.klug@ideasonboard.com>]

Hi Laurent,

Thank you for the patch.

Quoting Laurent Pinchart (2025-10-08 19:50:37)
> The v4l2_m2m_get_vq() function never returns NULL.
> 
> In the set format handler, the check may have been intended to catch
> invalid format types, but that's not needed as the V4L2 core picks the
> appropriate VIDIOC_S_FMT ioctl handler based on the format type, so the
> type can't be incorrect.
> 
> In the get format handler, the return value is not used for any purpose
> other than the NULL check, which was therefore probably intended to
> catch invalid format types. That's not needed for the same reason as in
> the set format handler.
> 
> Drop the unneeded return value checks and, as the function has no side
> effect, the unneeded function call as well.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> 

Cheers,
Stefan

> ---
>  drivers/media/platform/nxp/dw100/dw100.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
> index fed1788d0702..7a0ee44d9e1f 100644
> --- a/drivers/media/platform/nxp/dw100/dw100.c
> +++ b/drivers/media/platform/nxp/dw100/dw100.c
> @@ -765,13 +765,8 @@ static int dw100_enum_framesizes(struct file *file, void *priv,
>  static int dw100_g_fmt_vid(struct file *file, void *priv, struct v4l2_format *f)
>  {
>         struct dw100_ctx *ctx = dw100_file2ctx(file);
> -       struct vb2_queue *vq;
>         struct dw100_q_data *q_data;
>  
> -       vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
> -       if (!vq)
> -               return -EINVAL;
> -
>         q_data = dw100_get_q_data(ctx, f->type);
>  
>         f->fmt.pix_mp = q_data->pix_fmt;
> @@ -833,8 +828,6 @@ static int dw100_s_fmt(struct dw100_ctx *ctx, struct v4l2_format *f)
>         struct vb2_queue *vq;
>  
>         vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
> -       if (!vq)
> -               return -EINVAL;
>  
>         q_data = dw100_get_q_data(ctx, f->type);
>         if (!q_data)
> -- 
> Regards,
> 
> Laurent Pinchart
> 
>