From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78B6B3D9DA4; Thu, 14 May 2026 08:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778748228; cv=none; b=MGqiP0lj8OeAMycMcitXuVUp1FPRzWN1D+LJ5SdRMg+HgZNmYSnaEKnXoIBfm29uPA5+v/LjxFpka5o81Cqdyqqy5w2sRZTtbPRBIDF+UWKb7xqalhkdgXwr3FrAmj+5uUvkcf/hM8PSl431ZnsZccE//VSVms5Xl0ajX+bGJuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778748228; c=relaxed/simple; bh=sTCR9cEUYEm0CLV5LNEu//TBhcxgSBXYNGkopfZm/w8=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=mdY4uzIUp6/hxXo+cLGB1MxVh9sYTiC8HOFIkx5hGvooLybP1e2w5dd5DqyIJ9+jOAQ2d82nKH0Vxt+JHbfJCY/LSyJ94UpgDrqtQwHFVrAM3pm2IaczMkYRbEhlS6TcukLgJ3I6Bgc+MXWxXxQCDBa+xzTkVuqyK6Ug/3g3sK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=aoKD33+6; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aoKD33+6" Received: from monstersaurus.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BC01454; Thu, 14 May 2026 10:43:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778748217; bh=sTCR9cEUYEm0CLV5LNEu//TBhcxgSBXYNGkopfZm/w8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=aoKD33+6wOuX3Wn5eEGkKs9DlcVWk/NoL+KB6bzbk6cEEEhnsbTl/s0noLmi1zvKq wtQgSySj1p99OPGidzUBivT/1YaVR9I6EMuiRbN0V8tENkcVXYHy3XZRGSSVTAoBsg 1v8/zDXdDUGGpNtlzlutSSN+5sG7c9LmVqcYwWCE= Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20260501-ov5640_cleanup-v1-0-0869a7802a33@ideasonboard.com> <20260501-ov5640_cleanup-v1-5-0869a7802a33@ideasonboard.com> Subject: Re: [PATCH 05/11] media: i2c: ov5640: Remove unsupported bayer orders From: Kieran Bingham Cc: Sakari Ailus , Steve Longerbeam , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org To: Jacopo Mondi Date: Thu, 14 May 2026 09:43:42 +0100 Message-ID: <177874822267.2082999.7527544096525133469@ping.linuxembedded.co.uk> User-Agent: alot/0.9.1 Quoting Jacopo Mondi (2026-05-14 09:10:48) > Hi Kieran >=20 > On Fri, May 01, 2026 at 04:39:07PM +0100, Kieran Bingham wrote: > > The OV5640 only outputs SBGGR8. Remove the incorrectly advertised > > alternatives which allow a misconfigured pipeline to be established. >=20 > Do you have any idea why the datasheet mentions all the RGGB > permutations as valid outputs ? I would anticipate it's because the internal ISP component can support them. But now I think more I have to admit, I have no idea if other modules might have different physical orderings. But certainly as far as I can tell any given module can only have a single 'correct' value here. So we'll have to try to work out how to confirm/verify that perhaps ? >=20 > > > > Signed-off-by: Kieran Bingham > > --- > > drivers/media/i2c/ov5640.c | 21 --------------------- > > 1 file changed, 21 deletions(-) > > > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > > index 244c341d0e77..e1e253730206 100644 > > --- a/drivers/media/i2c/ov5640.c > > +++ b/drivers/media/i2c/ov5640.c > > @@ -309,27 +309,6 @@ static const struct ov5640_pixfmt ov5640_csi2_form= ats[] =3D { > > .bpp =3D 8, > > .ctrl00 =3D 0x00, > > .mux =3D OV5640_FMT_MUX_RAW_DPC, > > - }, { > > - /* Raw bayer, GBGB... / RGRG... */ > > - .code =3D MEDIA_BUS_FMT_SGBRG8_1X8, > > - .colorspace =3D V4L2_COLORSPACE_SRGB, > > - .bpp =3D 8, > > - .ctrl00 =3D 0x01, > > - .mux =3D OV5640_FMT_MUX_RAW_DPC, > > - }, { > > - /* Raw bayer, GRGR... / BGBG... */ > > - .code =3D MEDIA_BUS_FMT_SGRBG8_1X8, > > - .colorspace =3D V4L2_COLORSPACE_SRGB, > > - .bpp =3D 8, > > - .ctrl00 =3D 0x02, > > - .mux =3D OV5640_FMT_MUX_RAW_DPC, > > - }, { > > - /* Raw bayer, RGRG... / GBGB... */ > > - .code =3D MEDIA_BUS_FMT_SRGGB8_1X8, > > - .colorspace =3D V4L2_COLORSPACE_SRGB, > > - .bpp =3D 8, > > - .ctrl00 =3D 0x03, > > - .mux =3D OV5640_FMT_MUX_RAW_DPC, > > }, >=20 > Seems like you've missed the same entries in the ov5640_dvp_formats[] > table. That was intentional so far as I can only test the CSI variant. But perhaps for the same reasons mentioned above, whatever happens on one will be the same on the other. I hope posting this will find some wider testers 'perhaps' if anyone cares. -- Kieran. >=20 > > { /* sentinel */ } > > }; > > > > -- > > 2.52.0 > > > >