* [PATCH] Media: platform: vsp1: - Do not forget to call
@ 2016-11-25 5:07 Shailendra Verma
2016-11-25 13:42 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Shailendra Verma @ 2016-11-25 5:07 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Laurent Pinchart, linux-media,
linux-kernel, linux-renesas-soc, Shailendra Verma,
Shailendra Verma
Cc: vidushi.koul
v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition
before returing from the function.
Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
---
drivers/media/platform/vsp1/vsp1_video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
index d351b9c..cc58163 100644
--- a/drivers/media/platform/vsp1/vsp1_video.c
+++ b/drivers/media/platform/vsp1/vsp1_video.c
@@ -1044,6 +1044,7 @@ static int vsp1_video_open(struct file *file)
ret = vsp1_device_get(video->vsp1);
if (ret < 0) {
v4l2_fh_del(vfh);
+ v4l2_fh_exit(vfh);
kfree(vfh);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Media: platform: vsp1: - Do not forget to call
2016-11-25 5:07 [PATCH] Media: platform: vsp1: - Do not forget to call Shailendra Verma
@ 2016-11-25 13:42 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2016-11-25 13:42 UTC (permalink / raw)
To: Shailendra Verma
Cc: Mauro Carvalho Chehab, linux-media, linux-kernel,
linux-renesas-soc, Shailendra Verma, vidushi.koul
Hi Shailendra,
Thank you for the patch.
The subject line is missing something (and has an extra -), I would phrase it
as
"v4l: vsp1: Clean up file handle in open() error path"
(Mauro's scripts will add the "[media]" prefix when applying, so there's no
need to add it manually)
The same comment holds for all other patches in this series.
On Friday 25 Nov 2016 10:37:57 Shailendra Verma wrote:
> v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition
> before returing from the function.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
> drivers/media/platform/vsp1/vsp1_video.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> b/drivers/media/platform/vsp1/vsp1_video.c index d351b9c..cc58163 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -1044,6 +1044,7 @@ static int vsp1_video_open(struct file *file)
> ret = vsp1_device_get(video->vsp1);
> if (ret < 0) {
> v4l2_fh_del(vfh);
> + v4l2_fh_exit(vfh);
> kfree(vfh);
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-25 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-25 5:07 [PATCH] Media: platform: vsp1: - Do not forget to call Shailendra Verma
2016-11-25 13:42 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).