From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rick Chang <rick.chang@mediatek.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: mediatek: Add a binding for Mediatek JPEG Decoder
Date: Fri, 04 Nov 2016 17:56:29 +0200 [thread overview]
Message-ID: <1792025.53iDXU6qZ9@avalon> (raw)
In-Reply-To: <1478235060.23008.35.camel@mtksdaap41>
Hi Rick,
On Friday 04 Nov 2016 12:51:00 Rick Chang wrote:
> On Thu, 2016-11-03 at 20:34 +0200, Laurent Pinchart wrote:
> > On Thursday 03 Nov 2016 20:33:12 Laurent Pinchart wrote:
> >> On Monday 31 Oct 2016 15:16:55 Rick Chang wrote:
> >>> Add a DT binding documentation for Mediatek JPEG Decoder of
> >>> MT2701 SoC.
> >>>
> >>> Signed-off-by: Rick Chang <rick.chang@mediatek.com>
> >>> Signed-off-by: Minghsiu Tsai <minghsiu.tsai@mediatek.com>
> >>> ---
> >>>
> >>> .../bindings/media/mediatek-jpeg-codec.txt | 35 ++++++++++++++
> >>> 1 file changed, 35 insertions(+)
> >>> create mode 100644
> >>> Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt
> >>>
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt
> >>> b/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt new
> >>> file mode 100644
> >>> index 0000000..514e656
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt
> >>> @@ -0,0 +1,35 @@
> >>> +* Mediatek JPEG Codec
> >>
> >> Is it a codec or a decoder only ?
> >>
> >>> +Mediatek JPEG Codec device driver is a v4l2 driver which can decode
> >>> +JPEG-encoded video frames.
> >>
> >> DT bindings should not reference drivers, they are OS-agnostic.
> >>
> >>> +Required properties:
> >>> + - compatible : "mediatek,mt2701-jpgdec"
> >
> > Is the JPEG decoder found in MT2701 only, or in other Mediatek SoCs as
> > well ?
>
> Yes, the JPEG decoder is found in other Mediatek SoCs. However, the JPEG
> decoder HW in different SoCs have different register base, interrupt,
> power-domain and iommu setting.
That's fine, and that's exactly what the device tree is used for. When an
identical IP core is integrated differently in different SoCs, the driver
retrieves the resources (base address, clocks, IOMMU, interrupt, power domain
and more) from the device tree without any need for SoC-specific code.
> This patch series is only applicable in MT2701.
That was precisely my question, apart from integration properties, is there
anything specific to the MT2701 in patches 1/3 and 2/3 ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-11-04 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 7:16 [PATCH v2 0/3] Add Mediatek JPEG Decoder Rick Chang
2016-10-31 7:16 ` [PATCH v2 1/3] dt-bindings: mediatek: Add a binding for " Rick Chang
2016-11-03 18:33 ` Laurent Pinchart
2016-11-03 18:34 ` Laurent Pinchart
2016-11-04 4:51 ` Rick Chang
2016-11-04 15:56 ` Laurent Pinchart [this message]
2016-11-04 4:21 ` Rick Chang
2016-10-31 7:16 ` [PATCH v2 2/3] vcodec: mediatek: Add Mediatek JPEG Decoder Driver Rick Chang
2016-10-31 7:16 ` [PATCH v2 3/3] arm: dts: mt2701: Add node for Mediatek JPEG Decoder Rick Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1792025.53iDXU6qZ9@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=minghsiu.tsai@mediatek.com \
--cc=rick.chang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).