Re: [PATCH v2 1/6] V4L2: Add Renesas R-Car JPEG codec driver.

Sergei Shtylyov
2014-09-25T12:49:47Z

Hello.

On 9/23/2014 5:31 PM, Kamil Debski wrote:

>> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
>> owner@vger.kernel.org] On Behalf Of Mikhail Ulyanov
>> Sent: Monday, August 25, 2014 2:30 PM

>> This patch contains driver for Renesas R-Car JPEG codec.

>> Cnanges since v1:
>> - s/g_fmt function simplified
>> - default format for queues added
>> - dumb vidioc functions added to be in compliance with standard
>> api:
>> jpu_s_priority, jpu_g_priority
>> - standard v4l2_ctrl_subscribe_event and v4l2_event_unsubscribe
>> now in use by the same reason

> The patch looks good to me. However, I would suggest using the BIT macro

I'd prefer not using it since the driver #define's not only bits but also bit
values and multi-bit fields. Using BIT() would look inconsistent in this
situation.

> and making some short functions inline.

I think the current trend is to use *inline* only in the headers, and let
gcc figure it out itself in the .c files.

>> Signed-off-by: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com>

[...]
>> diff --git a/drivers/media/platform/jpu.c
>> b/drivers/media/platform/jpu.c new file mode 100644 index
>> 0000000..da70491
>> --- /dev/null
>> +++ b/drivers/media/platform/jpu.c
>> @@ -0,0 +1,1628 @@
[...]

> Best wishes,

WBR, Sergei