From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Arxh6yRb" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB1FF10F; Thu, 14 Dec 2023 07:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702567840; bh=L6OpDbiNLcyPXuRO6mFK0GaJHqzS5h9be+Rfj9yM16w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Arxh6yRblL+S+abOSng3LoCgobcTIFL1Sfj70f2rPJ2F8ICmR6jzWjb79Q+QzuR+l L7E4IYpViuGzezjARvfu0F/lwHVzCkK/m5lr2evtA44lae7kTzMJp+GziWwtAC4MvC uvILG76Uxa18u6cffX+b5hb25Xq8Y74P0yIyQ/CKt6tbnulkQ0OeY6g1+gD5a3uy0p swgdvEcQIxsN4SnGd4/hFT9C0SaBUj1lHYCNU6dQMDhYN2bjVb5olLum/2gO7gNeLM PVPW9TMDkBEEJPCgFGRLc0G+2qfKv2z6eB0yMPXZTxryzE4VU7tD7JiMZqZWU4VDxY 2U64vXmMe6KMA== Received: from [100.90.194.27] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 2B81A3781485; Thu, 14 Dec 2023 15:30:39 +0000 (UTC) Message-ID: <18406191-1b7c-490a-852b-eed3db23a3c1@collabora.com> Date: Thu, 14 Dec 2023 17:30:38 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: mediatek: mt8186: Add venc node Content-Language: en-US To: AngeloGioacchino Del Regno , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, Kyrie Wu , Allen-KH Cheng , Hsin-Yi Wang References: <20231213122017.102100-1-eugen.hristev@collabora.com> <20231213122017.102100-4-eugen.hristev@collabora.com> From: Eugen Hristev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/14/23 12:44, AngeloGioacchino Del Regno wrote: > Il 13/12/23 13:20, Eugen Hristev ha scritto: >> From: Kyrie Wu >> >> Add video encoder node. >> >> Signed-off-by: Kyrie Wu >> Signed-off-by: Allen-KH Cheng >> Reviewed-by: Hsin-Yi Wang >> [eugen.hristev@collabora.com: minor cleanup] >> Signed-off-by: Eugen Hristev >> --- >> arch/arm64/boot/dts/mediatek/mt8186.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi >> index 66ead3f23336..8535ff2b44e9 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi >> @@ -1993,6 +1993,30 @@ larb7: smi@17010000 { >> power-domains = <&spm MT8186_POWER_DOMAIN_VENC>; >> }; >> >> + venc: venc@17020000 { >> + compatible = "mediatek,mt8183-vcodec-enc"; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + reg = <0 0x17020000 0 0x2000>; >> + interrupts = ; >> + iommus = <&iommu_mm IOMMU_PORT_L7_VENC_RCPU>, >> + <&iommu_mm IOMMU_PORT_L7_VENC_REC>, >> + <&iommu_mm IOMMU_PORT_L7_VENC_BSDMA>, >> + <&iommu_mm IOMMU_PORT_L7_VENC_SV_COMV>, >> + <&iommu_mm IOMMU_PORT_L7_VENC_RD_COMV>, >> + <&iommu_mm IOMMU_PORT_L7_VENC_CUR_LUMA>, >> + <&iommu_mm IOMMU_PORT_L7_VENC_CUR_CHROMA>, >> + <&iommu_mm IOMMU_PORT_L7_VENC_REF_LUMA>, >> + <&iommu_mm IOMMU_PORT_L7_VENC_REF_CHROMA>; >> + dma-ranges = <0x1 0x0 0x1 0x0 0x1 0x0>; >> + mediatek,scp = <&scp>; >> + clocks = <&vencsys CLK_VENC_CKE1_VENC>; >> + clock-names = "MT_CG_VENC"; > > clock-names = "venc"; (please no underscores and please lower case) The clock name must be `venc_sel` (*with* underscores) and it's ABI as defined in Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml so I will it change to that. > >> + assigned-clocks = <&topckgen CLK_TOP_VENC>; >> + assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_D3>; >> + power-domains = <&spm MT8186_POWER_DOMAIN_VENC>; >> + }; > > > ....also: > > The following order of properties in device nodes is preferred: > > 1. "compatible" > 2. "reg" > 3. "ranges" > 4. Standard/common properties (defined by common bindings, e.g. without > vendor-prefixes) > 5. Vendor-specific properties > 6. "status" (if applicable) > 7. Child nodes, where each node is preceded with a blank line > > Documentation/devicetree/bindings/dts-coding-style.rst > > Please reorder as per the DTS coding style document, and also please rename the > venc node to use a generic name, such as "video-encoder@xxxx" > > Cheers, > Angelo > _______________________________________________ > Kernel mailing list -- kernel@mailman.collabora.com > To unsubscribe send an email to kernel-leave@mailman.collabora.com