From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: hyun.kwon@xilinx.com, mchehab@kernel.org,
michal.simek@xilinx.com, linux-media@vger.kernel.org,
Mirco Di Salvo <mirco.disalvo@iit.it>
Subject: Re: [PATCH] [media] v4l: xilinx: fix typo in formats table
Date: Fri, 28 Sep 2018 15:52:55 +0300 [thread overview]
Message-ID: <1859576.n3v8JWS4oW@avalon> (raw)
In-Reply-To: <20180928073213.10022-1-andrea.merello@gmail.com>
Hi Andrea,
Thank you for the patch.
On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
> In formats table the entry for CFA pattern "rggb" has GRBG fourcc.
> This patch fixes it.
>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it>
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Michal, should I take the patch in my tree ?
> ---
> drivers/media/platform/xilinx/xilinx-vip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/xilinx/xilinx-vip.c
> b/drivers/media/platform/xilinx/xilinx-vip.c index
> 311259129504..e9567cdfb89b 100644
> --- a/drivers/media/platform/xilinx/xilinx-vip.c
> +++ b/drivers/media/platform/xilinx/xilinx-vip.c
> @@ -36,7 +36,7 @@ static const struct xvip_video_format xvip_video_formats[]
> = { { XVIP_VF_MONO_SENSOR, 8, "mono", MEDIA_BUS_FMT_Y8_1X8,
> 1, V4L2_PIX_FMT_GREY, "Greyscale 8-bit" },
> { XVIP_VF_MONO_SENSOR, 8, "rggb", MEDIA_BUS_FMT_SRGGB8_1X8,
> - 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit RGGB" },
> + 1, V4L2_PIX_FMT_SRGGB8, "Bayer 8-bit RGGB" },
> { XVIP_VF_MONO_SENSOR, 8, "grbg", MEDIA_BUS_FMT_SGRBG8_1X8,
> 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit GRBG" },
> { XVIP_VF_MONO_SENSOR, 8, "gbrg", MEDIA_BUS_FMT_SGBRG8_1X8,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-09-28 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 7:32 [PATCH] [media] v4l: xilinx: fix typo in formats table Andrea Merello
2018-09-28 12:52 ` Laurent Pinchart [this message]
2018-10-01 12:45 ` Michal Simek
2018-10-01 13:26 ` Laurent Pinchart
2018-10-01 13:28 ` Michal Simek
2018-10-01 13:36 ` Laurent Pinchart
2018-10-01 14:06 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1859576.n3v8JWS4oW@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=andrea.merello@gmail.com \
--cc=hyun.kwon@xilinx.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mirco.disalvo@iit.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox