* [PATCH] [media] v4l: xilinx: fix typo in formats table
@ 2018-09-28 7:32 Andrea Merello
2018-09-28 12:52 ` Laurent Pinchart
0 siblings, 1 reply; 7+ messages in thread
From: Andrea Merello @ 2018-09-28 7:32 UTC (permalink / raw)
To: hyun.kwon, laurent.pinchart, mchehab, michal.simek
Cc: Andrea Merello, linux-media, Mirco Di Salvo
In formats table the entry for CFA pattern "rggb" has GRBG fourcc.
This patch fixes it.
Cc: linux-media@vger.kernel.org
Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it>
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
---
drivers/media/platform/xilinx/xilinx-vip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/xilinx/xilinx-vip.c b/drivers/media/platform/xilinx/xilinx-vip.c
index 311259129504..e9567cdfb89b 100644
--- a/drivers/media/platform/xilinx/xilinx-vip.c
+++ b/drivers/media/platform/xilinx/xilinx-vip.c
@@ -36,7 +36,7 @@ static const struct xvip_video_format xvip_video_formats[] = {
{ XVIP_VF_MONO_SENSOR, 8, "mono", MEDIA_BUS_FMT_Y8_1X8,
1, V4L2_PIX_FMT_GREY, "Greyscale 8-bit" },
{ XVIP_VF_MONO_SENSOR, 8, "rggb", MEDIA_BUS_FMT_SRGGB8_1X8,
- 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit RGGB" },
+ 1, V4L2_PIX_FMT_SRGGB8, "Bayer 8-bit RGGB" },
{ XVIP_VF_MONO_SENSOR, 8, "grbg", MEDIA_BUS_FMT_SGRBG8_1X8,
1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit GRBG" },
{ XVIP_VF_MONO_SENSOR, 8, "gbrg", MEDIA_BUS_FMT_SGBRG8_1X8,
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] [media] v4l: xilinx: fix typo in formats table
2018-09-28 7:32 [PATCH] [media] v4l: xilinx: fix typo in formats table Andrea Merello
@ 2018-09-28 12:52 ` Laurent Pinchart
2018-10-01 12:45 ` Michal Simek
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Pinchart @ 2018-09-28 12:52 UTC (permalink / raw)
To: Andrea Merello
Cc: hyun.kwon, mchehab, michal.simek, linux-media, Mirco Di Salvo
Hi Andrea,
Thank you for the patch.
On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
> In formats table the entry for CFA pattern "rggb" has GRBG fourcc.
> This patch fixes it.
>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it>
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Michal, should I take the patch in my tree ?
> ---
> drivers/media/platform/xilinx/xilinx-vip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/xilinx/xilinx-vip.c
> b/drivers/media/platform/xilinx/xilinx-vip.c index
> 311259129504..e9567cdfb89b 100644
> --- a/drivers/media/platform/xilinx/xilinx-vip.c
> +++ b/drivers/media/platform/xilinx/xilinx-vip.c
> @@ -36,7 +36,7 @@ static const struct xvip_video_format xvip_video_formats[]
> = { { XVIP_VF_MONO_SENSOR, 8, "mono", MEDIA_BUS_FMT_Y8_1X8,
> 1, V4L2_PIX_FMT_GREY, "Greyscale 8-bit" },
> { XVIP_VF_MONO_SENSOR, 8, "rggb", MEDIA_BUS_FMT_SRGGB8_1X8,
> - 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit RGGB" },
> + 1, V4L2_PIX_FMT_SRGGB8, "Bayer 8-bit RGGB" },
> { XVIP_VF_MONO_SENSOR, 8, "grbg", MEDIA_BUS_FMT_SGRBG8_1X8,
> 1, V4L2_PIX_FMT_SGRBG8, "Bayer 8-bit GRBG" },
> { XVIP_VF_MONO_SENSOR, 8, "gbrg", MEDIA_BUS_FMT_SGBRG8_1X8,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] [media] v4l: xilinx: fix typo in formats table
2018-09-28 12:52 ` Laurent Pinchart
@ 2018-10-01 12:45 ` Michal Simek
2018-10-01 13:26 ` Laurent Pinchart
0 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2018-10-01 12:45 UTC (permalink / raw)
To: Laurent Pinchart, Andrea Merello
Cc: hyun.kwon, mchehab, michal.simek, linux-media, Mirco Di Salvo
Hi Laurent,
On 28.9.2018 14:52, Laurent Pinchart wrote:
> Hi Andrea,
>
> Thank you for the patch.
>
> On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
>> In formats table the entry for CFA pattern "rggb" has GRBG fourcc.
>> This patch fixes it.
>>
>> Cc: linux-media@vger.kernel.org
>> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it>
>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Michal, should I take the patch in my tree ?
definitely. I am not collecting patches for media tree.
Thanks,
Michal
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] [media] v4l: xilinx: fix typo in formats table
2018-10-01 12:45 ` Michal Simek
@ 2018-10-01 13:26 ` Laurent Pinchart
2018-10-01 13:28 ` Michal Simek
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Pinchart @ 2018-10-01 13:26 UTC (permalink / raw)
To: Michal Simek
Cc: Andrea Merello, hyun.kwon, mchehab, linux-media, Mirco Di Salvo
Hi Michal,
On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote:
> On 28.9.2018 14:52, Laurent Pinchart wrote:
> > On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
> >> In formats table the entry for CFA pattern "rggb" has GRBG fourcc.
> >> This patch fixes it.
> >>
> >> Cc: linux-media@vger.kernel.org
> >> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it>
> >> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Michal, should I take the patch in my tree ?
>
> definitely. I am not collecting patches for media tree.
Taken in my tree.
By the way, have we reached any conclusion regarding https://lkml.org/lkml/
2017/12/18/112 ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] [media] v4l: xilinx: fix typo in formats table
2018-10-01 13:26 ` Laurent Pinchart
@ 2018-10-01 13:28 ` Michal Simek
2018-10-01 13:36 ` Laurent Pinchart
0 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2018-10-01 13:28 UTC (permalink / raw)
To: Laurent Pinchart, Michal Simek
Cc: Andrea Merello, hyun.kwon, mchehab, linux-media, Mirco Di Salvo
Hi Laurent,
On 1.10.2018 15:26, Laurent Pinchart wrote:
> Hi Michal,
>
> On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote:
>> On 28.9.2018 14:52, Laurent Pinchart wrote:
>>> On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
>>>> In formats table the entry for CFA pattern "rggb" has GRBG fourcc.
>>>> This patch fixes it.
>>>>
>>>> Cc: linux-media@vger.kernel.org
>>>> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it>
>>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
>>>
>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>
>>> Michal, should I take the patch in my tree ?
>>
>> definitely. I am not collecting patches for media tree.
>
> Taken in my tree.
>
> By the way, have we reached any conclusion regarding https://lkml.org/lkml/
> 2017/12/18/112 ?
Xilinx has started to use SPDX without any issue. It means conversion
should be fine to do.
Thanks,
Michal
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] [media] v4l: xilinx: fix typo in formats table
2018-10-01 13:28 ` Michal Simek
@ 2018-10-01 13:36 ` Laurent Pinchart
2018-10-01 14:06 ` Michal Simek
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Pinchart @ 2018-10-01 13:36 UTC (permalink / raw)
To: Michal Simek
Cc: Andrea Merello, hyun.kwon, mchehab, linux-media, Mirco Di Salvo
Hi Michal,
On Monday, 1 October 2018 16:28:32 EEST Michal Simek wrote:
> On 1.10.2018 15:26, Laurent Pinchart wrote:
> > On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote:
> >> On 28.9.2018 14:52, Laurent Pinchart wrote:
> >>> On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
> >>>> In formats table the entry for CFA pattern "rggb" has GRBG fourcc.
> >>>> This patch fixes it.
> >>>>
> >>>> Cc: linux-media@vger.kernel.org
> >>>> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it>
> >>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> >>>
> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >>>
> >>> Michal, should I take the patch in my tree ?
> >>
> >> definitely. I am not collecting patches for media tree.
> >
> > Taken in my tree.
> >
> > By the way, have we reached any conclusion regarding
> > https://lkml.org/lkml/
> > 2017/12/18/112 ?
>
> Xilinx has started to use SPDX without any issue. It means conversion
> should be fine to do.
That's good to know, I'll resubmit the patch then, and CC you to get an ack.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] [media] v4l: xilinx: fix typo in formats table
2018-10-01 13:36 ` Laurent Pinchart
@ 2018-10-01 14:06 ` Michal Simek
0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2018-10-01 14:06 UTC (permalink / raw)
To: Laurent Pinchart, Michal Simek
Cc: Andrea Merello, hyun.kwon, mchehab, linux-media, Mirco Di Salvo
On 1.10.2018 15:36, Laurent Pinchart wrote:
> Hi Michal,
>
> On Monday, 1 October 2018 16:28:32 EEST Michal Simek wrote:
>> On 1.10.2018 15:26, Laurent Pinchart wrote:
>>> On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote:
>>>> On 28.9.2018 14:52, Laurent Pinchart wrote:
>>>>> On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote:
>>>>>> In formats table the entry for CFA pattern "rggb" has GRBG fourcc.
>>>>>> This patch fixes it.
>>>>>>
>>>>>> Cc: linux-media@vger.kernel.org
>>>>>> Signed-off-by: Mirco Di Salvo <mirco.disalvo@iit.it>
>>>>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
>>>>>
>>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>>>
>>>>> Michal, should I take the patch in my tree ?
>>>>
>>>> definitely. I am not collecting patches for media tree.
>>>
>>> Taken in my tree.
>>>
>>> By the way, have we reached any conclusion regarding
>>> https://lkml.org/lkml/
>>> 2017/12/18/112 ?
>>
>> Xilinx has started to use SPDX without any issue. It means conversion
>> should be fine to do.
>
> That's good to know, I'll resubmit the patch then, and CC you to get an ack.
>
Sure go ahead.
M
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-01 20:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-28 7:32 [PATCH] [media] v4l: xilinx: fix typo in formats table Andrea Merello
2018-09-28 12:52 ` Laurent Pinchart
2018-10-01 12:45 ` Michal Simek
2018-10-01 13:26 ` Laurent Pinchart
2018-10-01 13:28 ` Michal Simek
2018-10-01 13:36 ` Laurent Pinchart
2018-10-01 14:06 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox