From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] uvcvideo: Return -EACCES when trying to access a read/write-only control
Date: Fri, 11 Jan 2013 14:31:12 +0100 [thread overview]
Message-ID: <1912507.Y1ty4L8jHZ@avalon> (raw)
In-Reply-To: <201301111426.28433.hverkuil@xs4all.nl>
Hi Hans,
On Friday 11 January 2013 14:26:28 Hans Verkuil wrote:
> On Fri January 11 2013 14:21:40 Hans Verkuil wrote:
> > On Fri January 11 2013 14:13:58 Laurent Pinchart wrote:
> > > Commit ba68c8530a263dc4de440fa10bb20a1c5b9d4ff5 (Partly revert "[media]
> > > uvcvideo: Set error_idx properly for extended controls API failures")
> > > also reverted commit 30ecb936cbcd83e3735625ac63e1b4466546f5fe
> > > ("uvcvideo: Return -EACCES when trying to access a read/write-only
> > > control") by mistake. Fix it.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> Actually, I need a clarification first: the code only checks for access to
> a read-only control, but the patch title says: "Return -EACCES when trying
> to access a read/write-only control", so either there is something missing
> in the patch, or the patch title is wrong.
>
> I suspect it is just the title that is wrong.
Yes, the title is wrong. The original commit handled both, and
ba68c8530a263dc4de440fa10bb20a1c5b9d4ff5 reverted only half of it.
I'll send a v2 with a fixed title.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-01-11 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 13:13 [PATCH 0/3] Fix uvcvideo revert leftovers Laurent Pinchart
2013-01-11 13:13 ` [PATCH 1/3] uvcvideo: Return -EACCES when trying to access a read/write-only control Laurent Pinchart
2013-01-11 13:21 ` Hans Verkuil
2013-01-11 13:26 ` Hans Verkuil
2013-01-11 13:31 ` Laurent Pinchart [this message]
2013-01-11 13:13 ` [PATCH 2/3] uvcvideo: Cleanup leftovers of partial revert Laurent Pinchart
2013-01-11 13:22 ` Hans Verkuil
2013-01-11 13:14 ` [PATCH 3/3] uvcvideo: Set error_idx properly for S_EXT_CTRLS failures Laurent Pinchart
2013-01-11 13:27 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1912507.Y1ty4L8jHZ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox