Re: [PATCH 1/2] Add TRACE_EVENTs in pwc_isoc_handler()

Steven Rostedt
2018-06-19T16:33:32Z

On Tue, 19 Jun 2018 19:23:04 +0300
"Matwey V. Kornilov" <matwey@sai.msu.ru> wrote:

> Hi Steven,
>
> Thank you for valuable comments.
>
> This is for measuring performance of URB completion callback inside PWC driver.
> What do you think about moving events to __usb_hcd_giveback_urb() in
> order to make this more generic? Like the following:
>
> local_irq_save(flags);
> // trace urb complete enter
> urb->complete(urb);
> // trace urb complete exit
> local_irq_restore(flags);
>
>

If that can work for you, I'm fine with that. Trace events may be
cheap, but they do come with some cost. I'd like to have all trace
events be as valuable as possible, and limit the "special case" ones.

-- Steve