From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: "Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, kernel@pengutronix.de
Subject: Re: [PATCH 080/117] media: sun6i_mipi_csi2: Convert to platform remove callback returning void
Date: Sun, 26 Mar 2023 20:18:33 +0200 [thread overview]
Message-ID: <1943376.usQuhbGJ8B@kista> (raw)
In-Reply-To: <20230326143224.572654-83-u.kleine-koenig@pengutronix.de>
Dne nedelja, 26. marec 2023 ob 16:31:47 CEST je Uwe Kleine-König napisal(a):
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
next prev parent reply other threads:[~2023-03-26 18:18 UTC|newest]
Thread overview: 172+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 14:30 [PATCH 000/117] media: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 001/117] media: cec-gpio: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 001/117] media: cros-ec-cec: Don't exit early in .remove() callback Uwe Kleine-König
2023-03-26 14:52 ` Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 002/117] media: cec-gpio: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-26 14:49 ` Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 002/117] media: cros-ec-cec: Don't exit early in .remove() callback Uwe Kleine-König
2023-03-26 14:45 ` Guenter Roeck
2023-03-27 7:52 ` Hans Verkuil
2023-03-26 14:30 ` [PATCH 003/117] media: cros-ec-cec: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-26 14:46 ` Guenter Roeck
2023-03-26 14:30 ` [PATCH 004/117] media: ao-cec-g12a: " Uwe Kleine-König
2023-04-03 20:39 ` Martin Blumenstingl
2023-03-26 14:30 ` [PATCH 005/117] media: ao-cec: " Uwe Kleine-König
2023-04-03 20:39 ` Martin Blumenstingl
2023-03-26 14:30 ` [PATCH 006/117] media: s5p_cec: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 007/117] media: seco-cec: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 008/117] media: stih-cec: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 009/117] media: stm32-cec: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 010/117] media: tegra_cec: " Uwe Kleine-König
2023-04-04 10:38 ` Thierry Reding
2023-03-26 14:30 ` [PATCH 011/117] media: rtl2832_sdr: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 012/117] media: zd1301_demod: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 013/117] media: allegro-core: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 014/117] media: ge2d: " Uwe Kleine-König
2023-04-03 20:40 ` Martin Blumenstingl
2023-03-26 14:30 ` [PATCH 015/117] media: vpu_core: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 016/117] media: vpu_drv: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 017/117] media: aspeed-video: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 018/117] media: atmel-isi: " Uwe Kleine-König
2023-04-03 11:32 ` Nicolas Ferre
2023-03-26 14:30 ` [PATCH 019/117] media: cdns-csi2rx: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 020/117] media: cdns-csi2tx: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 021/117] media: coda-common: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 022/117] media: pxa_camera: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 023/117] media: m2m-deinterlace: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 024/117] media: marvell: Simplify remove callback Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 025/117] media: marvell: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 026/117] media: mtk_jpeg_core: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 027/117] media: mtk_mdp_core: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 028/117] media: mtk-mdp3-core: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 029/117] media: mtk_vcodec_dec_drv: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 030/117] media: mtk_vcodec_enc_drv: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 031/117] media: mtk_vpu: " Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 032/117] media: microchip-csi2dc: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 033/117] media: microchip-sama5d2-isc: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 034/117] media: microchip-sama7g5-isc: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 035/117] media: vde: " Uwe Kleine-König
2023-04-04 10:39 ` Thierry Reding
2023-03-26 14:31 ` [PATCH 036/117] media: dw100: " Uwe Kleine-König
2023-03-27 6:56 ` Xavier Roumegue (OSS)
2023-03-26 14:31 ` [PATCH 037/117] media: mxc-jpeg: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 038/117] media: imx-mipi-csis: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 039/117] media: imx-pxp: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 040/117] media: imx7-media-csi: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 041/117] media: mx2_emmaprp: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 042/117] media: camss: " Uwe Kleine-König
2023-03-27 8:45 ` Konrad Dybcio
2023-03-26 14:31 ` [PATCH 043/117] media: venus: Warn only once about problems in .remove() Uwe Kleine-König
2023-03-27 8:45 ` Konrad Dybcio
2023-03-26 14:31 ` [PATCH 044/117] media: venus: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-27 8:45 ` Konrad Dybcio
2023-03-26 14:31 ` [PATCH 045/117] media: vdec: " Uwe Kleine-König
2023-03-27 8:46 ` Konrad Dybcio
2023-03-26 14:31 ` [PATCH 046/117] media: venc: " Uwe Kleine-König
2023-03-27 8:46 ` Konrad Dybcio
2023-03-26 14:31 ` [PATCH 047/117] media: rcar-fcp: " Uwe Kleine-König
2023-03-27 7:04 ` Geert Uytterhoeven
2023-03-26 14:31 ` [PATCH 048/117] media: rcar-isp: " Uwe Kleine-König
2023-03-27 7:10 ` Geert Uytterhoeven
2023-03-27 8:48 ` Niklas Söderlund
2023-03-26 14:31 ` [PATCH 049/117] media: rcar-core: " Uwe Kleine-König
2023-03-27 7:09 ` Geert Uytterhoeven
2023-03-27 8:47 ` Niklas Söderlund
2023-03-26 14:31 ` [PATCH 050/117] media: rcar-csi2: " Uwe Kleine-König
2023-03-27 7:13 ` Geert Uytterhoeven
2023-03-27 8:49 ` Niklas Söderlund
2023-03-26 14:31 ` [PATCH 051/117] media: rcar_drif: " Uwe Kleine-König
2023-03-27 7:12 ` Geert Uytterhoeven
2023-03-28 13:54 ` Fabrizio Castro
2023-03-26 14:31 ` [PATCH 052/117] media: rcar_fdp1: " Uwe Kleine-König
2023-03-27 7:12 ` Geert Uytterhoeven
2023-03-27 8:39 ` Kieran Bingham
2023-03-26 14:31 ` [PATCH 053/117] media: rcar_jpu: " Uwe Kleine-König
2023-03-27 7:11 ` Geert Uytterhoeven
2023-03-26 14:31 ` [PATCH 054/117] media: renesas-ceu: " Uwe Kleine-König
2023-03-27 7:13 ` Geert Uytterhoeven
2023-03-26 14:31 ` [PATCH 055/117] media: rzg2l-core: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 056/117] media: rzg2l-csi2: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 057/117] media: sh_vou: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 058/117] media: vsp1_drv: " Uwe Kleine-König
2023-03-27 7:11 ` Geert Uytterhoeven
2023-03-27 8:41 ` Kieran Bingham
2023-03-26 14:31 ` [PATCH 059/117] media: rga: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 060/117] media: rkisp1-dev: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 061/117] media: gsc-core: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 062/117] media: fimc-core: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 063/117] media: fimc-is-i2c: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 064/117] media: fimc-is: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 065/117] media: fimc-lite: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 066/117] media: media-dev: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 067/117] media: mipi-csis: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 068/117] media: camif-core: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 069/117] media: g2d: " Uwe Kleine-König
2023-04-03 9:53 ` Lukasz Stelmach
2023-03-26 14:31 ` [PATCH 070/117] media: jpeg-core: " Uwe Kleine-König
2023-03-27 12:31 ` Andrzej Pietrasiewicz
2023-03-26 14:31 ` [PATCH 071/117] media: s5p_mfc: " Uwe Kleine-König
2023-03-27 8:34 ` Andrzej Hajda
2023-03-26 14:31 ` [PATCH 072/117] media: bdisp-v4l2: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 073/117] media: c8sectpfe-core: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 074/117] media: delta-v4l2: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 075/117] media: hva-v4l2: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 076/117] media: dma2d: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 077/117] media: stm32-dcmi: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 078/117] media: sun4i_csi: " Uwe Kleine-König
2023-03-26 18:19 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 079/117] media: sun6i_csi: " Uwe Kleine-König
2023-03-26 18:19 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 080/117] media: sun6i_mipi_csi2: " Uwe Kleine-König
2023-03-26 18:18 ` Jernej Škrabec [this message]
2023-03-26 14:31 ` [PATCH 081/117] media: sun8i_a83t_mipi_csi2: " Uwe Kleine-König
2023-03-26 18:18 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 082/117] media: sun8i-di: " Uwe Kleine-König
2023-03-26 18:17 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 083/117] media: sun8i_rotate: " Uwe Kleine-König
2023-03-26 18:18 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 084/117] media: am437x-vpfe: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 085/117] media: cal: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 086/117] media: vpif: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 087/117] media: vpif_capture: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 088/117] media: vpif_display: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 089/117] media: omap_vout: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 090/117] media: isp: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 091/117] media: vpe: " Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 092/117] media: hantro_drv: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 093/117] media: via-camera: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 094/117] media: video-mux: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 095/117] media: xilinx-csi2rxss: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 096/117] media: xilinx-tpg: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 097/117] media: xilinx-vipp: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 098/117] media: xilinx-vtc: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 099/117] media: radio-si476x: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 100/117] media: radio-timb: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 101/117] media: radio-wl1273: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 102/117] media: radio-platform-si4713: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 103/117] media: gpio-ir-recv: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 104/117] media: img-ir-core: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 105/117] media: ir-hix5hd2: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 106/117] media: meson-ir-tx: " Uwe Kleine-König
2023-04-03 20:40 ` Martin Blumenstingl
2023-03-26 14:32 ` [PATCH 107/117] media: meson-ir: " Uwe Kleine-König
2023-04-03 20:41 ` Martin Blumenstingl
2023-03-26 14:32 ` [PATCH 108/117] media: mtk-cir: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 109/117] media: st_rc: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 110/117] media: sunxi-cir: " Uwe Kleine-König
2023-03-26 18:19 ` Jernej Škrabec
2023-03-26 14:32 ` [PATCH 111/117] media: vicodec-core: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 112/117] media: vidtv_bridge: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 113/117] media: vim2m: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 114/117] media: vimc-core: " Uwe Kleine-König
2023-03-27 8:42 ` Kieran Bingham
2023-03-27 15:25 ` Shuah Khan
2023-03-26 14:32 ` [PATCH 115/117] media: visl-core: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 116/117] media: vivid-core: " Uwe Kleine-König
2023-03-26 14:32 ` [PATCH 117/117] media: it913x: " Uwe Kleine-König
2023-04-17 6:02 ` [PATCH 000/117] media: " Uwe Kleine-König
2023-04-17 6:19 ` Laurent Pinchart
2023-04-17 7:30 ` Uwe Kleine-König
2023-04-17 7:35 ` Laurent Pinchart
2023-04-17 7:57 ` Biju Das
2023-04-17 8:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1943376.usQuhbGJ8B@kista \
--to=jernej.skrabec@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=samuel@sholland.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox